tici: read bucket and prefix from config file to create changefeed #2573

Lloyd-Pottiger · 2025-08-04T10:02:48Z

What problem does this PR solve?

close #xxx

What is changed and how it works?

tiup playground nightly --db.binpath ./dist/tidb-server --tiflash.binpath ./dist/tiflash/tiflash --tiflash.config ./ci/tiflash-reader-template.toml --ticdc 1 --ticdc.binpath ./dist/cdc --tici.meta 1 --tici.worker 1 --tici.binpath ./target/release --tici.config ./ci --tag xxx

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

ti-chi-bot · 2025-08-04T10:02:52Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

JaySon-Huang · 2025-08-06T08:26:38Z

components/playground/instance/tici.go


 	// Use default or provided config path
-	metaConfigPath := filepath.Join(t.ticiDir, "ci", "test-meta.toml")
+	metaConfigPath := filepath.Join(t.ticiDir, "../../ci", "test-meta.toml")


Why need to append "../../ci" to the "ticiDir"?
I think a better solution is provide different config file path as input param for metaservice and worker. For example --tici_meta_config --tici_worker_config

If we do not add --tici.config, it will try to use default config under tici/ci.

JaySon-Huang · 2025-08-06T08:30:04Z

components/playground/instance/tici.go

+	switch component {
+	case "tici-worker":
+		_, _ = colorstr.Printf("[dark_gray]Start %s instance: %s[reset]\n", component, fmt.Sprintf("%s/worker_node_service", t.ticiDir))
+	case "tici-meta":
+		_, _ = colorstr.Printf("[dark_gray]Start %s instance: %s[reset]\n", component, fmt.Sprintf("%s/meta_service_server", t.ticiDir))
+	}


I think a better solution is let tici build meta_service and worker_server into one binary and start different component with a cmd line argument.
For example, build one binary naming tici. And start tici-meta with tici meta --config=..., start tici-worker with tici worker --config=...

Leave it later.

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

ti-chi-bot · 2025-08-11T03:46:38Z

@kolafish: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

JaySon-Huang

LGTM

ti-chi-bot · 2025-08-11T03:55:26Z

@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

…ingcap#2573) * tici: refine config path Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> * fix Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> * fix Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> * fix Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> --------- Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

@wuhuizuo

* pkg/set: convert check to require (#2557) * meta: replace pingcap/check with testing (#2559) * embed: replace pingcap/check with testing (#2555) * base52: replace pingcap/check with testing (#2556) * localdata: replace pingcap/check with testing (#2561) * utils: replace pingcap/check with testing (#2562) * telemetry: remove (#2564) * Telemetry removal * Remove left over teleCommand * repo: exclude prerelease version from version list if possible (#2550) Signed-off-by: xhe <xw897002528@gmail.com> * repo: abstract v1repoapi as interface (#2542) * env: clean up old code Signed-off-by: xhe <xw897002528@gmail.com> * repo: leverage all apis into v1_repository Signed-off-by: xhe <xw897002528@gmail.com> * repo: abstract it as an interface Signed-off-by: xhe <xw897002528@gmail.com> * clean the remained part Signed-off-by: xhe <xw897002528@gmail.com> * rename to LocalComponentInstalled Signed-off-by: xhe <xw897002528@gmail.com> * update Signed-off-by: xhe <xw897002528@gmail.com> * try fix Signed-off-by: xhe <xw897002528@gmail.com> * g Signed-off-by: xhe <xw897002528@gmail.com> * try fix Signed-off-by: xhe <xw897002528@gmail.com> * g Signed-off-by: xhe <xw897002528@gmail.com> * g Signed-off-by: xhe <xw897002528@gmail.com> * g Signed-off-by: xhe <xw897002528@gmail.com> --------- Signed-off-by: xhe <xw897002528@gmail.com> * cluster: also check exporter ports (#2563) Signed-off-by: xhe <xw897002528@gmail.com> * cluster: improve SELinux compatibility (#2501) * cluster: improve SELinux compatibility * fixup * cluster: update --ssh desc (#2380) * Update --ssh desc * Update components/cluster/command/root.go --------- Co-authored-by: xhe <xw897002528@gmail.com> * cluster: add stop/start timeout for systemd service (#2568) Signed-off-by: xhe <xw897002528@gmail.com> * *: move insight to tiup (#2553) * Move insight to tiup * Fix linting issues * Fix unused/gocritic/staticcheck issues * *: check_to_require for cluster (#2566) * check_to_require: cluster * Restore TestCountDirMultiPath --------- Co-authored-by: xhe <xw897002528@gmail.com> * *: update dmpb (#2569) * Update dmpb * Remove dm grpc gw * *: replace otiai10/copy with os.CopyFS (#2571) * ci: add staging mirror option to release workflow (#2576) * ci: fix STAGING version competition (#2579) * playground: fix config typo (#2578) Signed-off-by: Ryan Leung <rleungx@gmail.com> * ci: add ci for feature branch (#2577) Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> * ci: fix staging version string (#2582) * ci: fix STAGING version competition * ci: replace slashes with dots in branch name for STAGING_VER * Apply suggestion from @wuhuizuo * playground: add tici component in playground (#2546) * add tici component in playground * fix: resolve lint errors in tici.go - Add comments for exported constants TiCIRoleMeta and TiCIRoleWorker - Remove extra empty line in NewTiCIInstanceWithRole function - Replace interface{} with any for Go 1.18+ compatibility * fix: update golangci-lint config for v2 and Makefile - Add version: 2 to golangci.yaml for golangci-lint v2 compatibility - Remove typecheck from enabled linters (not a linter in v2) - Update Makefile to use golangci-lint v2.1.6 (latest) * fix: add comment to clarify executor mock setup in test - Add explanatory comment to TestCheckConfig method - This helps understand the purpose of the mock setup for better test readability * fix compile error * revert makefile * modify the sleep time and adjust the cdc server * Update components/playground/instance/tici.go --------- Co-authored-by: xhe <xw897002528@gmail.com> * tici: Update the default config filename & default port of tici (#2567) * Update the default config filename Signed-off-by: JaySon-Huang <tshent@qq.com> * Update default port Signed-off-by: JaySon-Huang <tshent@qq.com> --------- Signed-off-by: JaySon-Huang <tshent@qq.com> * tici: refine binpath (#2572) Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> * tici: read bucket and prefix from config file to create changefeed (#2573) * tici: refine config path Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> * fix Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> * fix Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> * fix Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> --------- Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> * playground: make the tici changefeed endpoint configurable (#2581) * playground: make the tici changefeed endpoint configurable * address comments * *: support start a TiDB playground cluster with TiCI without any self-defined binarys or configurations (#2583) Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> * fix Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> * fix Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> --------- Signed-off-by: xhe <xw897002528@gmail.com> Signed-off-by: Ryan Leung <rleungx@gmail.com> Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> Signed-off-by: JaySon-Huang <tshent@qq.com> Co-authored-by: Daniël van Eeden <git@myname.nl> Co-authored-by: xhe <xw897002528@gmail.com> Co-authored-by: glkappe <qihang.li@pingcap.com> Co-authored-by: wuhuizuo <wuhuizuo@126.com> Co-authored-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: Yu Jin <yujin.yujin@gmail.com> Co-authored-by: JaySon <tshent@qq.com> Co-authored-by: Yiding Cui <winoros@gmail.com>

tici: refine config path

bf1517b

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

ti-chi-bot bot requested review from kaaaaaaang and nexustar August 4, 2025 10:02

ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 4, 2025

fix

be5f11f

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 6, 2025

Lloyd-Pottiger changed the title ~~tici: refine config path~~ tici: read bucket and prefix from config file to create changefeed Aug 6, 2025

JaySon-Huang reviewed Aug 6, 2025

View reviewed changes

fix

242bc9e

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 11, 2025

fix

983c1f6

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

kolafish approved these changes Aug 11, 2025

View reviewed changes

JaySon-Huang approved these changes Aug 11, 2025

View reviewed changes

xhebox merged commit 44dd29a into pingcap:feature/fts Aug 11, 2025
2 of 3 checks passed

Lloyd-Pottiger deleted the refine-path branch August 11, 2025 04:58

Lloyd-Pottiger mentioned this pull request Aug 14, 2025

Merge master into feature/fts #2585

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

tici: read bucket and prefix from config file to create changefeed #2573

tici: read bucket and prefix from config file to create changefeed #2573

Uh oh!

Lloyd-Pottiger commented Aug 4, 2025 •

edited

Loading

Uh oh!

ti-chi-bot bot commented Aug 4, 2025

Uh oh!

JaySon-Huang Aug 6, 2025 •

edited

Loading

Uh oh!

Lloyd-Pottiger Aug 6, 2025

Uh oh!

JaySon-Huang Aug 6, 2025

Uh oh!

Lloyd-Pottiger Aug 6, 2025

Uh oh!

ti-chi-bot bot commented Aug 11, 2025

Uh oh!

JaySon-Huang left a comment

Uh oh!

ti-chi-bot bot commented Aug 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tici: read bucket and prefix from config file to create changefeed #2573

tici: read bucket and prefix from config file to create changefeed #2573

Uh oh!

Conversation

Lloyd-Pottiger commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Uh oh!

ti-chi-bot bot commented Aug 4, 2025

Uh oh!

JaySon-Huang Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lloyd-Pottiger Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

JaySon-Huang Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

Lloyd-Pottiger Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Aug 11, 2025

Uh oh!

JaySon-Huang left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Aug 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Lloyd-Pottiger commented Aug 4, 2025 •

edited

Loading

JaySon-Huang Aug 6, 2025 •

edited

Loading