tici: Update the default config filename & default port of tici #2567

JaySon-Huang · 2025-07-31T02:30:13Z

What problem does this PR solve?

close #xxx

What is changed and how it works?

Update the default config filename of tici according to https://github.com/pingcap-inc/tici/pull/221
Update the default port of tici according to https://github.com/pingcap-inc/tici/pull/232

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

Signed-off-by: JaySon-Huang <tshent@qq.com>

ti-chi-bot · 2025-07-31T02:30:17Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2025-07-31T02:33:09Z

@Lloyd-Pottiger: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

JinheLin · 2025-08-01T03:37:08Z

Please also update the default port of tici worker to 8510 in

tiup/components/playground/instance/tici.go

Line 76 in e1af356

defaultPort = 8501 // WorkerNode default port

Signed-off-by: JaySon-Huang <tshent@qq.com>

ti-chi-bot · 2025-08-01T04:33:50Z

[LGTM Timeline notifier]

Timeline:

2025-08-01 04:33:50.450717159 +0000 UTC m=+238643.135987385: ☑️ agreed by xhebox.

…cap#2567) * Update the default config filename Signed-off-by: JaySon-Huang <tshent@qq.com> * Update default port Signed-off-by: JaySon-Huang <tshent@qq.com> --------- Signed-off-by: JaySon-Huang <tshent@qq.com>

@wuhuizuo

* pkg/set: convert check to require (#2557) * meta: replace pingcap/check with testing (#2559) * embed: replace pingcap/check with testing (#2555) * base52: replace pingcap/check with testing (#2556) * localdata: replace pingcap/check with testing (#2561) * utils: replace pingcap/check with testing (#2562) * telemetry: remove (#2564) * Telemetry removal * Remove left over teleCommand * repo: exclude prerelease version from version list if possible (#2550) Signed-off-by: xhe <xw897002528@gmail.com> * repo: abstract v1repoapi as interface (#2542) * env: clean up old code Signed-off-by: xhe <xw897002528@gmail.com> * repo: leverage all apis into v1_repository Signed-off-by: xhe <xw897002528@gmail.com> * repo: abstract it as an interface Signed-off-by: xhe <xw897002528@gmail.com> * clean the remained part Signed-off-by: xhe <xw897002528@gmail.com> * rename to LocalComponentInstalled Signed-off-by: xhe <xw897002528@gmail.com> * update Signed-off-by: xhe <xw897002528@gmail.com> * try fix Signed-off-by: xhe <xw897002528@gmail.com> * g Signed-off-by: xhe <xw897002528@gmail.com> * try fix Signed-off-by: xhe <xw897002528@gmail.com> * g Signed-off-by: xhe <xw897002528@gmail.com> * g Signed-off-by: xhe <xw897002528@gmail.com> * g Signed-off-by: xhe <xw897002528@gmail.com> --------- Signed-off-by: xhe <xw897002528@gmail.com> * cluster: also check exporter ports (#2563) Signed-off-by: xhe <xw897002528@gmail.com> * cluster: improve SELinux compatibility (#2501) * cluster: improve SELinux compatibility * fixup * cluster: update --ssh desc (#2380) * Update --ssh desc * Update components/cluster/command/root.go --------- Co-authored-by: xhe <xw897002528@gmail.com> * cluster: add stop/start timeout for systemd service (#2568) Signed-off-by: xhe <xw897002528@gmail.com> * *: move insight to tiup (#2553) * Move insight to tiup * Fix linting issues * Fix unused/gocritic/staticcheck issues * *: check_to_require for cluster (#2566) * check_to_require: cluster * Restore TestCountDirMultiPath --------- Co-authored-by: xhe <xw897002528@gmail.com> * *: update dmpb (#2569) * Update dmpb * Remove dm grpc gw * *: replace otiai10/copy with os.CopyFS (#2571) * ci: add staging mirror option to release workflow (#2576) * ci: fix STAGING version competition (#2579) * playground: fix config typo (#2578) Signed-off-by: Ryan Leung <rleungx@gmail.com> * ci: add ci for feature branch (#2577) Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> * ci: fix staging version string (#2582) * ci: fix STAGING version competition * ci: replace slashes with dots in branch name for STAGING_VER * Apply suggestion from @wuhuizuo * playground: add tici component in playground (#2546) * add tici component in playground * fix: resolve lint errors in tici.go - Add comments for exported constants TiCIRoleMeta and TiCIRoleWorker - Remove extra empty line in NewTiCIInstanceWithRole function - Replace interface{} with any for Go 1.18+ compatibility * fix: update golangci-lint config for v2 and Makefile - Add version: 2 to golangci.yaml for golangci-lint v2 compatibility - Remove typecheck from enabled linters (not a linter in v2) - Update Makefile to use golangci-lint v2.1.6 (latest) * fix: add comment to clarify executor mock setup in test - Add explanatory comment to TestCheckConfig method - This helps understand the purpose of the mock setup for better test readability * fix compile error * revert makefile * modify the sleep time and adjust the cdc server * Update components/playground/instance/tici.go --------- Co-authored-by: xhe <xw897002528@gmail.com> * tici: Update the default config filename & default port of tici (#2567) * Update the default config filename Signed-off-by: JaySon-Huang <tshent@qq.com> * Update default port Signed-off-by: JaySon-Huang <tshent@qq.com> --------- Signed-off-by: JaySon-Huang <tshent@qq.com> * tici: refine binpath (#2572) Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> * tici: read bucket and prefix from config file to create changefeed (#2573) * tici: refine config path Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> * fix Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> * fix Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> * fix Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> --------- Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> * playground: make the tici changefeed endpoint configurable (#2581) * playground: make the tici changefeed endpoint configurable * address comments * *: support start a TiDB playground cluster with TiCI without any self-defined binarys or configurations (#2583) Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> * fix Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> * fix Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> --------- Signed-off-by: xhe <xw897002528@gmail.com> Signed-off-by: Ryan Leung <rleungx@gmail.com> Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> Signed-off-by: JaySon-Huang <tshent@qq.com> Co-authored-by: Daniël van Eeden <git@myname.nl> Co-authored-by: xhe <xw897002528@gmail.com> Co-authored-by: glkappe <qihang.li@pingcap.com> Co-authored-by: wuhuizuo <wuhuizuo@126.com> Co-authored-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: Yu Jin <yujin.yujin@gmail.com> Co-authored-by: JaySon <tshent@qq.com> Co-authored-by: Yiding Cui <winoros@gmail.com>

Update the default config filename

2e3fb54

Signed-off-by: JaySon-Huang <tshent@qq.com>

ti-chi-bot bot requested review from nexustar and srstack July 31, 2025 02:30

ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 31, 2025

Lloyd-Pottiger approved these changes Jul 31, 2025

View reviewed changes

Update default port

f111da6

Signed-off-by: JaySon-Huang <tshent@qq.com>

ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 1, 2025

JaySon-Huang changed the title ~~tici: Update the default config filename of tici~~ tici: Update the default config filename & default port of tici Aug 1, 2025

xhebox approved these changes Aug 1, 2025

View reviewed changes

ti-chi-bot bot added the lgtm label Aug 1, 2025

xhebox merged commit a8b1c8c into pingcap:feature/fts Aug 1, 2025
2 of 3 checks passed

JaySon-Huang deleted the update_tici_playground branch August 1, 2025 04:38

Lloyd-Pottiger mentioned this pull request Aug 14, 2025

Merge master into feature/fts #2585

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

tici: Update the default config filename & default port of tici #2567

tici: Update the default config filename & default port of tici #2567

Uh oh!

JaySon-Huang commented Jul 31, 2025 •

edited

Loading

Uh oh!

ti-chi-bot bot commented Jul 31, 2025

Uh oh!

ti-chi-bot bot commented Jul 31, 2025

Uh oh!

JinheLin commented Aug 1, 2025

Uh oh!

ti-chi-bot bot commented Aug 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tici: Update the default config filename & default port of tici #2567

tici: Update the default config filename & default port of tici #2567

Uh oh!

Conversation

JaySon-Huang commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Uh oh!

ti-chi-bot bot commented Jul 31, 2025

Uh oh!

ti-chi-bot bot commented Jul 31, 2025

Uh oh!

JinheLin commented Aug 1, 2025

Uh oh!

ti-chi-bot bot commented Aug 1, 2025

[LGTM Timeline notifier]

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JaySon-Huang commented Jul 31, 2025 •

edited

Loading