-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tiup cluster prune need to delete storage.remote.cache.dir #2142
Conversation
Signed-off-by: hehechen <awd123456sss@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2142 +/- ##
==========================================
+ Coverage 50.99% 56.24% +5.25%
==========================================
Files 313 313
Lines 33302 33308 +6
==========================================
+ Hits 16981 18733 +1752
+ Misses 14289 12340 -1949
- Partials 2032 2235 +203
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 68 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: hehechen <awd123456sss@gmail.com>
/merge |
@kaaaaaaang: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 64ec3e8
|
@hehechen: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
After pingcap/tiflash#6967, TiFlash has added
storage.remote.cache.dir
config, so tiup cluster prune need to delete storage.remote.cache.dir of TiFlash.What is changed and how it works?
tiup cluster prune support to delete storage.remote.cache.dir of TiFlash.
Check List
Tests
./tiup-cluster prune ctl-test-2
Check if the
storage.remote.cache.dir
has been deleted.Code changes
Side effects
Related changes
Release notes: