tiup cluster prune need to delete storage.remote.cache.dir (#2142)

pingcap · Mar 21, 2023 · 05db4f1 · 05db4f1
1 parent d8e9242
commit 05db4f1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/pkg/cluster/operation/destroy.go b/pkg/cluster/operation/destroy.go
@@ -376,6 +376,15 @@ func DestroyComponent(ctx context.Context, instances []spec.Instance, cls spec.T
 			}
 		}
 
+		// For TiFlash, we need to delete storage.remote.cache.dir
+		if ins.ComponentName() == spec.ComponentTiFlash {
+			tiflashInstance := ins.(*spec.TiFlashInstance)
+			tiflashSpec := tiflashInstance.InstanceSpec.(*spec.TiFlashSpec)
+			if remoteCacheDir, ok := tiflashSpec.Config[spec.TiFlashRemoteCacheDir]; ok {
+				delPaths.Insert(remoteCacheDir.(string))
+			}
+		}
+
 		logDir := ins.LogDir()
 
 		// In TiDB-Ansible, deploy dir are shared by all components on the same

diff --git a/pkg/cluster/spec/tiflash.go b/pkg/cluster/spec/tiflash.go
@@ -153,6 +153,7 @@ const (
 	TiFlashStorageKeyMainDirs   string = "storage.main.dir"
 	TiFlashStorageKeyLatestDirs string = "storage.latest.dir"
 	TiFlashStorageKeyRaftDirs   string = "storage.raft.dir"
+	TiFlashRemoteCacheDir       string = "storage.remote.cache.dir"
 	TiFlashRequiredCPUFlags     string = "avx2 popcnt movbe"
 )