owner(cdc): clean up admin jobs on async close #6129
Conversation
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/work-in-progress
ti-chi-bot
added
size/M
cdc/owner/owner.go
Outdated
| @@ -571,9 +573,30 @@ func (o *ownerImpl) takeOwnerJobs() []*ownerJob { | |||
| func (o *ownerImpl) pushOwnerJob(job *ownerJob) { | |||
| o.ownerJobQueue.Lock() | |||
| defer o.ownerJobQueue.Unlock() | |||
| if atomic.LoadInt32(&o.closed) != 0 { | |||
| log.Info("reject owner job as owner has been closed") | |||
There was a problem hiding this comment.
how about also log the rejected job?
ti-chi-bot
added
status/LGT2
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 932d5a0
|
ti-chi-bot
added
the
status/can-merge
|
/run-all-tests |
|
@overvenus: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
) * syncer(dm): init schemaTracker when syncer run (#6052) close #6014 * cdc: upgrade pebble and stabilize a case (#6116) close #5798 * meta(engine): Resourcemeta support job level isolation (#5817) close #5816 * owner(cdc): clean up admin jobs on async close (#6129) close #6128 * pkg/errctx(engine): avoid creating goroutinue in errctx (#6061) ref #6013 * cdc,pkg: accommodate systemd TimeoutStopSec and k8s terminationGracePeriodSeconds (#6097) * cdc,pkg: accommodate systemd TimeoutStopSec and k8s terminationGracePeriodSeconds * cdc: correct drain capture doc Signed-off-by: Neil Shen <overvenus@gmail.com> * cdc: drain waits for owner resign and table move out Signed-off-by: Neil Shen <overvenus@gmail.com> * tp(cdc): make drain capture scheduler aware of capture state Signed-off-by: Neil Shen <overvenus@gmail.com> * cdc: remove verbose log and set liveness stop after resign owner Signed-off-by: Neil Shen <overvenus@gmail.com> * cdc: skip owner resign when there is only one capture Signed-off-by: Neil Shen <overvenus@gmail.com> * fix ut * apply comments * fix integration test * fix lint Co-authored-by: Obliviate <756541536@qq.com> Co-authored-by: qupeng <qupeng@pingcap.com> Co-authored-by: maxshuang <huangguohao@pingcap.com> Co-authored-by: Neil Shen <overvenus@gmail.com> Co-authored-by: Yujie Xia <xiayjchn@gmail.com>
What problem does this PR solve?
Issue Number: close #6128
What is changed and how it works?
Clean up admin jobs and reject future jobs on async close.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note