cdc,pkg: accommodate systemd TimeoutStopSec and k8s terminationGracePeriodSeconds #6097
Conversation
…eriodSeconds Signed-off-by: Neil Shen <overvenus@gmail.com>
overvenus
added
area/ticdc
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
|
/run-all-tests |
|
LGTM |
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
/run-unit-test |
|
/merge |
|
@3AceShowHand: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/run-kafka-integration-test |
| @@ -704,7 +704,7 @@ func (h *OpenAPI) ListCapture(c *gin.Context) { | |||
| // @Produce json | |||
| // @Success 200,202 | |||
| // @Failure 500,400 {object} model.HTTPError | |||
| // @Router /api/v1/captures/drain [post] | |||
| // @Router /api/v1/captures/drain [put] | |||
There was a problem hiding this comment.
It's a correction. It have been changed into PUT by #6044.
…eriodSeconds (pingcap#6097) * cdc,pkg: accommodate systemd TimeoutStopSec and k8s terminationGracePeriodSeconds * cdc: correct drain capture doc Signed-off-by: Neil Shen <overvenus@gmail.com>
…eriodSeconds (#6097) * cdc,pkg: accommodate systemd TimeoutStopSec and k8s terminationGracePeriodSeconds * cdc: correct drain capture doc Signed-off-by: Neil Shen <overvenus@gmail.com>
) * syncer(dm): init schemaTracker when syncer run (#6052) close #6014 * cdc: upgrade pebble and stabilize a case (#6116) close #5798 * meta(engine): Resourcemeta support job level isolation (#5817) close #5816 * owner(cdc): clean up admin jobs on async close (#6129) close #6128 * pkg/errctx(engine): avoid creating goroutinue in errctx (#6061) ref #6013 * cdc,pkg: accommodate systemd TimeoutStopSec and k8s terminationGracePeriodSeconds (#6097) * cdc,pkg: accommodate systemd TimeoutStopSec and k8s terminationGracePeriodSeconds * cdc: correct drain capture doc Signed-off-by: Neil Shen <overvenus@gmail.com> * cdc: drain waits for owner resign and table move out Signed-off-by: Neil Shen <overvenus@gmail.com> * tp(cdc): make drain capture scheduler aware of capture state Signed-off-by: Neil Shen <overvenus@gmail.com> * cdc: remove verbose log and set liveness stop after resign owner Signed-off-by: Neil Shen <overvenus@gmail.com> * cdc: skip owner resign when there is only one capture Signed-off-by: Neil Shen <overvenus@gmail.com> * fix ut * apply comments * fix integration test * fix lint Co-authored-by: Obliviate <756541536@qq.com> Co-authored-by: qupeng <qupeng@pingcap.com> Co-authored-by: maxshuang <huangguohao@pingcap.com> Co-authored-by: Neil Shen <overvenus@gmail.com> Co-authored-by: Yujie Xia <xiayjchn@gmail.com>
What problem does this PR solve?
Issue Number: ref #4757
What is changed and how it works?
Add liveness to TiCDC.
TiCDC sets liveness to Stopping upon receiving SIGTERM.
The exit perdure wait TiCDC drains all its tables and ownership (not implemented yet).
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note