cdc: upgrade pebble and stabilize a case #6116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: qupeng <qupeng@pingcap.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
Signed-off-by: qupeng <qupeng@pingcap.com>
ti-chi-bot
added
size/M
Signed-off-by: qupeng <qupeng@pingcap.com>
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #6116 +/- ##
================================================
+ Coverage 57.7148% 57.7508% +0.0359%
================================================
Files 699 701 +2
Lines 82743 82785 +42
================================================
+ Hits 47755 47809 +54
+ Misses 30637 30617 -20
- Partials 4351 4359 +8 |
overvenus
approved these changes
Jun 29, 2022
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 64b5793
|
ti-chi-bot
added
the
status/can-merge
|
/run-dm-integration-test |
asddongmen
pushed a commit
that referenced
this pull request
Jul 1, 2022
) * syncer(dm): init schemaTracker when syncer run (#6052) close #6014 * cdc: upgrade pebble and stabilize a case (#6116) close #5798 * meta(engine): Resourcemeta support job level isolation (#5817) close #5816 * owner(cdc): clean up admin jobs on async close (#6129) close #6128 * pkg/errctx(engine): avoid creating goroutinue in errctx (#6061) ref #6013 * cdc,pkg: accommodate systemd TimeoutStopSec and k8s terminationGracePeriodSeconds (#6097) * cdc,pkg: accommodate systemd TimeoutStopSec and k8s terminationGracePeriodSeconds * cdc: correct drain capture doc Signed-off-by: Neil Shen <overvenus@gmail.com> * cdc: drain waits for owner resign and table move out Signed-off-by: Neil Shen <overvenus@gmail.com> * tp(cdc): make drain capture scheduler aware of capture state Signed-off-by: Neil Shen <overvenus@gmail.com> * cdc: remove verbose log and set liveness stop after resign owner Signed-off-by: Neil Shen <overvenus@gmail.com> * cdc: skip owner resign when there is only one capture Signed-off-by: Neil Shen <overvenus@gmail.com> * fix ut * apply comments * fix integration test * fix lint Co-authored-by: Obliviate <756541536@qq.com> Co-authored-by: qupeng <qupeng@pingcap.com> Co-authored-by: maxshuang <huangguohao@pingcap.com> Co-authored-by: Neil Shen <overvenus@gmail.com> Co-authored-by: Yujie Xia <xiayjchn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: qupeng qupeng@pingcap.com
What problem does this PR solve?
Issue Number: close #5798
What is changed and how it works?
Upgrade pebble, and use
DisableAutomaticCompactionsfor that test case.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note