planner: reimplement DEFAULT function to make the behavior consistent with MySQL when looking up the corresponding column #19709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with MySQL when looking up the corresponding column
rebelice
requested review from
wshwsh12 and
winoros
and removed request for
a team
|
/label component/planner |
|
These labels are not found |
|
/label sig/planner |
|
/run-all-tests |
|
/run-all-tests parser=pr/1007 |
ichn-hu
reviewed
Sep 2, 2020
|
/run-all-tests parser=pr/1007 |
|
/run-unit-test parser=pr/1007 |
1 similar comment
|
/run-unit-test parser=pr/1007 |
|
Please fix conflicts @rebelice . |
|
/run-all-tests |
|
/run-all-tests |
|
/run-sqllogic-test-2 |
|
/run-common-test |
|
/merge |
lzmhhh123
approved these changes
Sep 18, 2020
ti-srebot
approved these changes
Sep 18, 2020
|
/run-all-tests |
|
/run-check_dev |
|
/label needs-cherry-pick-4.0 |
|
/run-cherry-picker |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Nov 26, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #21316 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #17807
Problem Summary:
The previous Default function parsed to generate ast.ColumnName, and then further parsed the corresponding column. But in fact, the Default function does not need to obtain the value of the corresponding column from the storage, so it should not be further parsed by ast.ColumnName.
The previous implementation produced many incompatibility issues with MySQL, such as:
select b from t order by default(a)will return Unknown columna, even ifthas columna.Have to merge pingcap/parser#1027 first.
What is changed and how it works?
Proposal: xxx
What's Changed:
allNamesforPlanBuilderandexpressionRewriterto record the set of columns that can be used to find inevalDefaultExpr.evalDefaultExpr. And frist, it will look forallNames. If it is not found, it will search inexpressionRewrite.names.Check List
Tests
Side effects
Release note