-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: reimplement DEFAULT function to make the behavior consistent with MySQL when looking up the corresponding column #19709
Merged
Merged
Changes from 16 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
1c15a39
planner: Reimplement DEFAULT function to make the behavior consistent…
rebelice 0022233
add one more test
rebelice ebbddf8
replace parser to rebelice/parser
rebelice 5cfb1f5
add comments
rebelice 56c360f
Merge remote-tracking branch 'upstream/master' into dev19537
rebelice fe7fb67
replace parser to rebelice/parser
rebelice 56c3594
reset go.mod and go.sum
rebelice 2dc6082
Merge branch 'master' into dev19537
rebelice 9aedef1
merge master
rebelice f4ba107
update go mod
rebelice 0285317
update go mod
rebelice ecb6f5d
add comments
rebelice 1a1eb08
merge upstream/master
rebelice 9003ce7
modify comments
rebelice 6da637a
Merge branch 'master' into dev19537
qw4990 05813d5
address comment
rebelice 3fd0e5f
update go mod
rebelice ccaeb2f
Merge branch 'master' into dev19537
rebelice 57d0e55
update go mod
rebelice 42e5317
Merge branch 'dev19537' of github.com:rebelice/tidb into dev19537
rebelice ebfa7db
Merge branch 'master' into dev19537
lzmhhh123 7a8af39
Merge branch 'master' into dev19537
lzmhhh123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please add some test that is invalid in resolving column names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It exists at
https://github.com/pingcap/tidb/pull/19709/files#diff-1e69525b01b51d983863da3fe1d4a21fR93