-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: reimplement DEFAULT function to make the behavior consistent with MySQL when looking up the corresponding column (#19709) #21316
Merged
qw4990
merged 8 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-e880cae49188
Nov 30, 2020
Merged
planner: reimplement DEFAULT function to make the behavior consistent with MySQL when looking up the corresponding column (#19709) #21316
qw4990
merged 8 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-e880cae49188
Nov 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
ti-srebot
added
component/expression
sig/planner
SIG: Planner
type/4.0-cherry-pick
labels
Nov 26, 2020
@rebelice you're already a collaborator in bot's repo. |
PTAL @qw4990 @lzmhhh123 |
qw4990
reviewed
Nov 30, 2020
ichn-hu
approved these changes
Nov 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
qw4990
approved these changes
Nov 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/expression
sig/planner
SIG: Planner
status/LGT2
Indicates that a PR has LGTM 2.
type/4.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #19709 to release-4.0
What problem does this PR solve?
Issue Number: close #17807
Problem Summary:
The previous Default function parsed to generate ast.ColumnName, and then further parsed the corresponding column. But in fact, the Default function does not need to obtain the value of the corresponding column from the storage, so it should not be further parsed by ast.ColumnName.
The previous implementation produced many incompatibility issues with MySQL, such as:
select b from t order by default(a)
will return Unknown columna
, even ift
has columna
.Have to merge pingcap/parser#1027 first.
What is changed and how it works?
Proposal: xxx
What's Changed:
allNames
forPlanBuilder
andexpressionRewriter
to record the set of columns that can be used to find inevalDefaultExpr
.evalDefaultExpr
. And frist, it will look forallNames
. If it is not found, it will search inexpressionRewrite.names
.Check List
Tests
Side effects
Release note