feat: select all profiling types and instances by default #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
shhdgit
pushed a commit
to shhdgit/tidb-dashboard
that referenced
this pull request
May 16, 2022
shhdgit
pushed a commit
to shhdgit/tidb-dashboard
that referenced
this pull request
May 16, 2022
shhdgit
pushed a commit
to shhdgit/tidb-dashboard
that referenced
this pull request
May 16, 2022
breezewish
pushed a commit
that referenced
this pull request
May 17, 2022
* fix: missing fields in slowquery * fix dev build exit unexpectedly (#1207) * fix wrong time unit for slow query (#1212) * invalidate assets cache (#1208) * enable query when conprof is disabled (#1217) * feat: improve statement (#1234) * misc: bump ech (#1238) * feat: use ech for overview charts (#1241) * feat: show more metrics in overview (#1242) * feat: show info about data delay for Top SQL (#1244) * feat: multi-line logs by default (#1245) * feat: enlarge log display area (#1248) * feat: select all profiling types and instances by default (#1249) * fix: prevent enter overview page before auth (#1251) * ui: polish the layout of profiling (#1253) * feat: do not autoload data when network slow in slow query (#1254) * ui: small polish (#1260)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User only needs to click "Start Profiling"! No need to select multiple options any more.
This is a small feature extracted from #1148