Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use ech for overview charts #1241

Merged
merged 1 commit into from
May 8, 2022
Merged

Conversation

breezewish
Copy link
Member

Finally drag-drop to change time range is possible now:

image

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2022

Codecov Report

Merging #1241 (adf225c) into master (2cb74ec) will increase coverage by 0.42%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #1241      +/-   ##
==========================================
+ Coverage   31.44%   31.87%   +0.42%     
==========================================
  Files         289      297       +8     
  Lines       17013    17092      +79     
  Branches      667      680      +13     
==========================================
+ Hits         5350     5448      +98     
+ Misses      11432    11413      -19     
  Partials      231      231              
Flag Coverage Δ
be_integration_test_latest 9.29% <ø> (ø)
be_integration_test_v4.0.1 9.32% <ø> (ø)
be_unit_test 24.11% <ø> (ø)
e2e_test 77.15% <80.00%> (+1.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cb74ec...adf225c. Read the comment docs.

@breezewish breezewish merged commit 67ec2fd into master May 8, 2022
@breezewish breezewish deleted the improvements/overview-charts branch May 8, 2022 06:16
shhdgit pushed a commit to shhdgit/tidb-dashboard that referenced this pull request May 16, 2022
shhdgit pushed a commit to shhdgit/tidb-dashboard that referenced this pull request May 16, 2022
shhdgit pushed a commit to shhdgit/tidb-dashboard that referenced this pull request May 16, 2022
breezewish pushed a commit that referenced this pull request May 17, 2022
* fix: missing fields in slowquery
* fix dev build exit unexpectedly (#1207)
* fix wrong time unit for slow query (#1212)
* invalidate assets cache (#1208)
* enable query when conprof is disabled (#1217)
* feat: improve statement (#1234)
* misc: bump ech (#1238)
* feat: use ech for overview charts (#1241)
* feat: show more metrics in overview (#1242)
* feat: show info about data delay for Top SQL (#1244)
* feat: multi-line logs by default (#1245)
* feat: enlarge log display area (#1248)
* feat: select all profiling types and instances by default (#1249)
* fix: prevent enter overview page before auth (#1251)
* ui: polish the layout of profiling (#1253)
* feat: do not autoload data when network slow in slow query (#1254)
* ui: small polish (#1260)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants