Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dev build exit unexpectedly #1207

Merged
merged 1 commit into from
Apr 1, 2022
Merged

fix dev build exit unexpectedly #1207

merged 1 commit into from
Apr 1, 2022

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Apr 1, 2022

The build process for dev will exit unexpectedly when rebuild meets errors because we don't catch the error, we can reproduce it by deleting a necessary file.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 1, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breeswish

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2022

Codecov Report

Merging #1207 (91c0e9d) into master (3ec0447) will increase coverage by 9.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1207      +/-   ##
==========================================
+ Coverage   22.34%   31.63%   +9.28%     
==========================================
  Files         164      290     +126     
  Lines       14139    17097    +2958     
  Branches        0      683     +683     
==========================================
+ Hits         3159     5408    +2249     
- Misses      10749    11458     +709     
  Partials      231      231              
Flag Coverage Δ
be_integration_test_latest 9.29% <ø> (-0.05%) ⬇️
be_integration_test_v4.0.1 9.27% <ø> (ø)
be_unit_test 24.07% <ø> (ø)
e2e_test 76.03% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ec0447...91c0e9d. Read the comment docs.

@baurine baurine merged commit 371316e into master Apr 1, 2022
@baurine baurine deleted the fix-dev-build branch April 1, 2022 01:50
shhdgit pushed a commit to shhdgit/tidb-dashboard that referenced this pull request May 16, 2022
shhdgit pushed a commit to shhdgit/tidb-dashboard that referenced this pull request May 16, 2022
shhdgit pushed a commit to shhdgit/tidb-dashboard that referenced this pull request May 16, 2022
breezewish pushed a commit that referenced this pull request May 17, 2022
* fix: missing fields in slowquery
* fix dev build exit unexpectedly (#1207)
* fix wrong time unit for slow query (#1212)
* invalidate assets cache (#1208)
* enable query when conprof is disabled (#1217)
* feat: improve statement (#1234)
* misc: bump ech (#1238)
* feat: use ech for overview charts (#1241)
* feat: show more metrics in overview (#1242)
* feat: show info about data delay for Top SQL (#1244)
* feat: multi-line logs by default (#1245)
* feat: enlarge log display area (#1248)
* feat: select all profiling types and instances by default (#1249)
* fix: prevent enter overview page before auth (#1251)
* ui: polish the layout of profiling (#1253)
* feat: do not autoload data when network slow in slow query (#1254)
* ui: small polish (#1260)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants