Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TiKV store status information #6949

Merged
merged 12 commits into from
Mar 31, 2022
Merged

Update TiKV store status information #6949

merged 12 commits into from
Mar 31, 2022

Conversation

en-jin19
Copy link
Contributor

@en-jin19 en-jin19 commented Nov 23, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

Added the relationship between a TiKV store in "faq/deploy-and-maintain-faq.md", "pd-control.md", and "tidb-scheduling.md".

Which TiDB version(s) do your changes apply to? (Required)

Although most of Chinese PRs are only applied to master, newly updated PR #8723 updated the contents from v4.0 to master, for consistency, this PR will be also applied to the corresponding versions.

  • master (the latest development version)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  1. For the "faq/deploy-and-maintain-faq.md", it is translated from Docs: revise the status information of a TiKV store docs-cn#7338.
  2. For the "pd-control.md", it is translated from docs: update TiKV store status information docs-cn#7177.
  3. For the "tidb-scheduling.md", it is translated from Docs: revise the status information of a TiKV store docs-cn#7338 and docs: update the TiKV store status description docs-cn#8723.
  4. For the newly added image, it is translated from docs: update TiKV store status information docs-cn#7177.
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@en-jin19 en-jin19 added type/enhancement The issue or PR belongs to an enhancement. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. labels Nov 23, 2021
@en-jin19 en-jin19 requested review from nolouch and TomShawn November 23, 2021 10:58
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 23, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 23, 2021
@en-jin19
Copy link
Contributor Author

en-jin19 commented Nov 23, 2021 •
edited by TomShawn
Loading

@nolouch @TomShawn could you please help confirm which versions this content affects?

@ti-chi-bot
Copy link
Member

@nolouch: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

TomShawn
TomShawn reviewed Dec 10, 2021
View reviewed changes
pd-control.md Outdated Show resolved Hide resolved
@en-jin19 @TomShawn
Apply suggestions from code review
cbe6671 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@en-jin19 en-jin19 added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Feb 14, 2022
@en-jin19 en-jin19 self-assigned this Mar 9, 2022
@lilin90 lilin90 changed the title add the relationship between a TiKV store Update TiKV store status information Mar 14, 2022
@lilin90
Copy link
Member

lilin90 commented Mar 14, 2022

@nolouch @TomShawn could you please which versions does this content affect?

@en-jin19 Has this been confirmed? If not, please further confirm the updates and try to get this PR merged.

@lilin90
Copy link
Member

lilin90 commented Mar 14, 2022 •
edited
Loading

@en-jin19 And please fix the checkbox syntax in the PR description box, and make it consistent with the label used for this PR.
image

en-jin19
en-jin19 commented Mar 15, 2022
View reviewed changes
pd-control.md Outdated Show resolved Hide resolved
en-jin19
en-jin19 commented Mar 15, 2022
View reviewed changes
tidb-scheduling.md Outdated Show resolved Hide resolved
en-jin19
en-jin19 commented Mar 15, 2022
View reviewed changes
tidb-scheduling.md Outdated Show resolved Hide resolved
en-jin19
en-jin19 commented Mar 15, 2022
View reviewed changes
tidb-scheduling.md Outdated Show resolved Hide resolved
@en-jin19 en-jin19 removed the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Mar 16, 2022
shichun-0415
shichun-0415 reviewed Mar 16, 2022
View reviewed changes
faq/deploy-and-maintain-faq.md Outdated
@@ -266,6 +266,10 @@ PD can tolerate any synchronization error, but a larger error value means a larg

The client connection can only access the cluster through TiDB. TiDB connects PD and TiKV. PD and TiKV are transparent to the client. When TiDB connects to any PD, the PD tells TiDB who is the current leader. If this PD is not the leader, TiDB reconnects to the leader PD.

#### What is the relationship between each status (Up, Disconnect, Offline, Down, Tombstone) of a TiKV store?

You can use PD Control to check the status information of a TiKV store. For the relationship between each status, refer to [Relationship between each status of a TiKV store](/tidb-scheduling.md#information-collection).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

标题问的是各状态之间的关系，好像不需要解释怎么查看状态，另外，建议直接给出关系的描述，链接跳转来跳转去体验不会很好。附上下面的图是不是就可以了？
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个图表示的各状态之间的关系其实不是特别清晰的，适合用作为辅助材料。

另外，为了直接回答标题问题，感觉可以把两句的顺序调换过来。毕竟如果解释了关系，可能也有人会好奇那要看这些关系需要怎么操作。

pd-control.md Outdated Show resolved Hide resolved
pd-control.md Outdated Show resolved Hide resolved
tidb-scheduling.md Outdated Show resolved Hide resolved
tidb-scheduling.md Outdated Show resolved Hide resolved
tidb-scheduling.md Outdated Show resolved Hide resolved
@en-jin19 @shichun-0415
Apply suggestions from code review
9e09f1a 
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
@en-jin19
Copy link
Contributor Author

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 31, 2022
@en-jin19
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5b27776

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 31, 2022
@ti-chi-bot ti-chi-bot merged commit f38041c into pingcap:master Mar 31, 2022
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Mar 31, 2022
@en-jin19 @ti-chi-bot
This is an automated cherry-pick of pingcap#6949
911b8cc 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 31, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7998.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 31, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7999.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 31, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8000.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 31, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8001.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 31, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8002.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 31, 2022
Merged
14 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8003.

en-jin19 added a commit that referenced this pull request Mar 31, 2022
@en-jin19
Revert "Update TiKV store status information (#6949)"
172bed3 
This reverts commit f38041c.
ti-chi-bot added a commit that referenced this pull request Mar 31, 2022
@ti-chi-bot
Update TiKV store status information (#6949) (#8001)
996d2ca
ti-chi-bot added a commit that referenced this pull request Mar 31, 2022
@ti-chi-bot
Update TiKV store status information (#6949) (#8002)
383cdcd
ti-chi-bot added a commit that referenced this pull request Mar 31, 2022
@ti-chi-bot
Update TiKV store status information (#6949) (#8003)
23da125
ti-chi-bot added a commit that referenced this pull request Mar 31, 2022
@ti-chi-bot
Update TiKV store status information (#6949) (#8000)
58bf07a
ti-chi-bot added a commit that referenced this pull request Mar 31, 2022
@ti-chi-bot
Update TiKV store status information (#6949) (#7999)
4f1ef8d
@en-jin19 en-jin19 mentioned this pull request Mar 31, 2022
Merged
15 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 1, 2022
Merged
15 tasks
ti-chi-bot added a commit that referenced this pull request Apr 2, 2022
@ti-chi-bot
Update TiKV store status information (#6949) (#7998)
710faf2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@nolouch nolouch nolouch approved these changes

@JmPotato JmPotato JmPotato approved these changes

Assignees

@en-jin19 en-jin19

Labels
area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@en-jin19 @ti-chi-bot @lilin90 @JmPotato @nolouch @TomShawn @shichun-0415