Skip to content

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Mar 22, 2022

Signed-off-by: JmPotato ghzpotato@gmail.com

What is changed, added or deleted? (Required)

Refine the TiKV store status description.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 22, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn March 22, 2022 06:55
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 22, 2022
@JmPotato
Copy link
Member Author

/cc @en-jin19 @shichun-0415

@shichun-0415 shichun-0415 added type/enhancement The issue or PR belongs to an enhancement. translation/doing This PR’s assignee is translating this PR. area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. and removed missing-translation-status This PR does not have translation status info. labels Mar 22, 2022
@JmPotato JmPotato force-pushed the refine_tikv_store_status branch from 793799b to f400373 Compare March 22, 2022 07:06
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Thanks.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 22, 2022
@shichun-0415 shichun-0415 added the require-LGT1 Indicates that the PR requires an LGTM. label Mar 22, 2022
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f400373

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 22, 2022
@shichun-0415 shichun-0415 added needs-cherry-pick-release-4.0 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Mar 22, 2022
@ti-chi-bot ti-chi-bot merged commit 690312b into pingcap:master Mar 22, 2022
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Mar 22, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8727.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/docs-cn#release-5.2 from head ti-chi-bot:cherry-pick-8723-to-release-5.2: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-8723-to-release-5.2."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Mar 22, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Mar 22, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8728.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8729.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Mar 22, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8730.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Mar 22, 2022
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #8731.

@JmPotato JmPotato deleted the refine_tikv_store_status branch March 22, 2022 09:38
@en-jin19 en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants