-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TiKV store status information #6949
Merged
ti-chi-bot
merged 12 commits into
pingcap:master
from
en-jin19:add-tikv-store-status-relationship
Mar 31, 2022
Merged
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
abf38da
add the relationship between a TiKV store
en-jin19 cbe6671
Apply suggestions from code review
en-jin19 c1cdf04
Apply suggestions from code review
en-jin19 9ee554d
Apply suggestions from code review
en-jin19 12b7a4c
update the image
en-jin19 9e09f1a
Apply suggestions from code review
en-jin19 bcd20e3
update image file
en-jin19 5f38ee9
Apply suggestions from code review
en-jin19 39d8065
Apply suggestions from code review
en-jin19 b44cb5a
Apply suggestions from code review
en-jin19 2d3f340
Apply suggestions from code review
en-jin19 5b27776
Apply suggestions from code review
en-jin19 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
标题问的是各状态之间的关系,好像不需要解释怎么查看状态,另外,建议直接给出关系的描述,链接跳转来跳转去体验不会很好。附上下面的图是不是就可以了?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个图表示的各状态之间的关系其实不是特别清晰的,适合用作为辅助材料。
另外,为了直接回答标题问题,感觉可以把两句的顺序调换过来。毕竟如果解释了关系,可能也有人会好奇那要看这些关系需要怎么操作。