Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove expression index out of experimental feature. #4641

Merged
merged 5 commits into from
Oct 10, 2020

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Oct 9, 2020

Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 9, 2020
@TomShawn TomShawn added size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. v5.0 This PR/issue applies to TiDB v5.0 labels Oct 9, 2020
```sql
allow-expression-index = true
```

TiDB 不仅能将索引建立在表中的一个或多个列上,还可以将索引建立在一个表达式上。当查询涉及表达式时,表达式索引能够加速这些查询。
Copy link
Contributor

@TomShawn TomShawn Oct 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个功能在 5.0 中是默认开启吗?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的,和上个PR, auto random 一样。因为是之前是实验特性,加入开关是为了避免用户轻易使用。现在移出实验特性后,用户就可以直接使用。和其他功能的开关不太一样,这里在去掉后就没有什么打开和关闭的概念了。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

所以不用特地说明该功能是默认开启的?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomShawn TomShawn added the status/require-change Needs the author to address comments. label Oct 9, 2020
@ti-srebot
Copy link
Contributor

@wjhuang2016,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: docs(slack).

@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Oct 9, 2020
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Oct 10, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 10, 2020
@ti-srebot
Copy link
Contributor

@wjhuang2016,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: docs(slack).

@TomShawn TomShawn merged commit 325e5be into pingcap:master Oct 10, 2020
@Joyinqin
Copy link
Contributor

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Oct 12, 2020
@Joyinqin
Copy link
Contributor

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR’s assignee is translating this PR. label Oct 12, 2020
wjhuang2016 added a commit to wjhuang2016/docs-cn that referenced this pull request Dec 14, 2020
TomShawn added a commit that referenced this pull request Dec 15, 2020
…" (#5089)

This reverts commit 325e5be.

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
wjhuang2016 added a commit to wjhuang2016/docs-cn that referenced this pull request Jul 8, 2021
* done

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>

* fmt

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/small Changes of a small size. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.0 This PR/issue applies to TiDB v5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants