-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: remove expression index out of experimental feature. #4641
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
```sql | ||
allow-expression-index = true | ||
``` | ||
|
||
TiDB 不仅能将索引建立在表中的一个或多个列上,还可以将索引建立在一个表达式上。当查询涉及表达式时,表达式索引能够加速这些查询。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个功能在 5.0 中是默认开启吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是的,和上个PR, auto random 一样。因为是之前是实验特性,加入开关是为了避免用户轻易使用。现在移出实验特性后,用户就可以直接使用。和其他功能的开关不太一样,这里在去掉后就没有什么打开和关闭的概念了。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
所以不用特地说明该功能是默认开启的?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯
@wjhuang2016,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: docs(slack). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@wjhuang2016,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: docs(slack). |
/label translation/done |
/unlabel translation/doing |
* done Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com> * fmt Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?