-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: remove expression index out of the experiment feature #19998
Conversation
@@ -30,7 +30,7 @@ require ( | |||
github.com/opentracing/opentracing-go v1.1.0 | |||
github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2 | |||
github.com/pingcap/badger v1.5.1-0.20200810065601-8c92a97807f9 | |||
github.com/pingcap/br v0.0.0-20200820083933-d9d6207c0aa7 | |||
github.com/pingcap/br v0.0.0-20200915060630-cc1a3924f33e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why update this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refer to pingcap/br#503
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve conflicts @wjhuang2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
@wjhuang2016 merge failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com
What problem does this PR solve?
Remove expression index out of the experiment feature.
What is changed and how it works?
N/A
Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
Release note