Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc: add docs for insecure-skip-verify #14073

Merged
merged 1 commit into from
May 30, 2023
Merged

ticdc: add docs for insecure-skip-verify #14073

merged 1 commit into from
May 30, 2023

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented May 29, 2023 •
edited by Oreoxmt
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Rustin170506
ticdc: add docs for insecure-skip-verify
ac24c7c 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 29, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 29, 2023
@Rustin170506 Rustin170506 requested a review from ran-huang May 29, 2023 10:04
@ran-huang ran-huang added v7.1 This PR/issue applies to TiDB v7.1. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. translation/doing This PR’s assignee is translating this PR. labels May 29, 2023
@ran-huang ran-huang self-assigned this May 29, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label May 29, 2023
This was referenced May 29, 2023
Merged
Merged
@Oreoxmt Oreoxmt self-requested a review May 29, 2023 10:45
@Oreoxmt Oreoxmt added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label May 29, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 29, 2023
@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels May 29, 2023
Oreoxmt
Oreoxmt approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 30, 2023
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 30, 2023

This pull request has been accepted and is ready to merge.

Commit hash: ac24c7c

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 30, 2023
@ti-chi-bot ti-chi-bot bot merged commit edefc17 into pingcap:master May 30, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #14080.

This was referenced May 30, 2023
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request May 30, 2023
@ti-chi-bot
ticdc: add docs for insecure-skip-verify (#14073) (#14080)
2f7f92f
@Oreoxmt Oreoxmt mentioned this pull request Jun 13, 2023
Merged
17 tasks
@Oreoxmt Oreoxmt added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jun 13, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #14206.

This was referenced Jun 13, 2023
Merged
Merged
ran-huang pushed a commit that referenced this pull request Jun 14, 2023
@ti-chi-bot @Rustin170506 @Oreoxmt
ticdc: add docs for insecure-skip-verify (#14073) (#14206)
10ec4f1 
* ticdc: add docs for insecure-skip-verify

Signed-off-by: hi-rustin <rustin.liu@gmail.com>

* Apply suggestions from code review

---------

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Co-authored-by: hi-rustin <rustin.liu@gmail.com>
Co-authored-by: Aolin <aolin.zhang@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@ran-huang ran-huang ran-huang approved these changes

Assignees

@ran-huang ran-huang

Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.1 This PR/issue applies to TiDB v7.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rustin170506 @ran-huang @ti-chi-bot @Oreoxmt