Repository navigation
[2026.3][Studio] Translate layout titles in language comparison view - #4170
Merged
jcPimcore merged 4 commits intoOct 7, 2026
Merged
Conversation
The section header in the language comparison view rendered the raw layout title key (e.g. Product.layout.general) because the breadcrumb segments were never passed through the translation function. Translate each segment at render time, as the versions view already does. Refs PEES-1593 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Memoized content does not refresh translated titles when the UI language changes.
Review effort: Balanced
Findings: 1
What changed in this PR
Translates language-comparison section breadcrumbs instead of displaying raw translation keys.
Changes:
- Applies
t()to each slash-delimited breadcrumb segment.
| File | Description |
|---|---|
language-comparison-content.tsx |
Translates section-title segments during rendering. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
renderedContent is memoized and now evaluates t() for section titles, so add t to its dependencies to re-render when the language changes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Product.layout.general) as section headers.renderSectionTitlenow passes each breadcrumb segment throught()after splitting on/, mirroringobject-versions-fields-view.tsx.groupIntoSections(grouping is keyed on the breadcrumb string) and covers brick/field-collection breadcrumbs. Plain-string titles fall back to themselves.Refs PEES-1593. Reported against 2026.2, which is closed for bugfix releases, so this targets 2026.3.
Resolves pimcore/platform-version#410
Verification
🤖 Generated with Claude Code