Skip to content

[2026.3][Studio] Translate layout titles in language comparison view #4170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcPimcore merged 4 commits into from
Oct 7, 2026
Merged

[2026.3][Studio] Translate layout titles in language comparison view #4170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70904af
[2026.3][Studio] Translate layout titles in language comparison view
jcPimcore Oct 7, 2026
66dfaf9
Automatic frontend build
jcPimcore Oct 7, 2026
cf8d29f
[Studio] Refresh language comparison titles on UI language change
jcPimcore Oct 7, 2026
07c7dae
Automatic frontend build
jcPimcore Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...dules/data-object/editor/toolbar/language-comparison-view/language-comparison-content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

import React, { useMemo } from 'react'
import { ConfigProvider, theme } from 'antd'
import { useTranslation } from 'react-i18next'
import cn from 'classnames'
import { isEmpty, isNil, isUndefined } from 'lodash'
import { isEmptyValue } from '@Pimcore/utils/type-utils'
Expand Down Expand Up @@ -56,11 +57,12 @@ const groupIntoSections = (items: ILocalizedFieldDescriptor[]): ILocalizedSectio
export const LanguageComparisonContent = ({ layoutData, locales, editableLanguages, isAllowedToEdit }: ILanguageComparisonColumnProps): React.JSX.Element => {
const { styles } = useStyles()
const { token } = theme.useToken()
const { t } = useTranslation()

const renderSectionTitle = ({ breadcrumbTitle, hideSectionTitle }: { breadcrumbTitle: string, hideSectionTitle: boolean }): React.JSX.Element | null => {
if (isEmptyValue(breadcrumbTitle)) return null

const titleParts = breadcrumbTitle.split('/')
const titleParts = breadcrumbTitle.split('/').map(part => t(part))
Comment thread
jcPimcore marked this conversation as resolved.
const [firstTitlePart, ...remainingTitleParts] = titleParts
const secondTitlePart = remainingTitleParts.length > 0 ? ` | ${remainingTitleParts.join(' | ')}` : ''

Expand Down Expand Up @@ -180,7 +182,7 @@ export const LanguageComparisonContent = ({ layoutData, locales, editableLanguag
))}
</Flex>
)
}, [locales, sections])
}, [locales, sections, t])

return (
<ConfigProvider theme={ { components: { Form: { itemMarginBottom: token.marginXS } } } }>
Expand Down
Binary file renamed build-dist/build-7c845b2a53b9.zip → build-dist/build-1a4356b56357.zip
View file
Open in desktop
Binary file not shown.
Loading