Skip to content

Add CI test for Rust features#422

Merged
cd-work merged 5 commits intomainfrom
1984
May 31, 2022
Merged

Add CI test for Rust features#422
cd-work merged 5 commits intomainfrom
1984

Conversation

@cd-work
Copy link
Contributor

@cd-work cd-work commented May 24, 2022

This adds a separate test step for all available features, to ensure
that the current WIP development features also build without any issue.

Fixes #357.

@cd-work cd-work requested a review from a team May 24, 2022 19:29
@cd-work cd-work requested a review from a team as a code owner May 24, 2022 19:29
@cd-work cd-work requested review from mathew-horner and maxrake May 24, 2022 19:29
@cd-work cd-work force-pushed the 1984 branch 2 times, most recently from f65535f to f612ea2 Compare May 24, 2022 19:33
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging these changes will introduce failing tests to CI...which is good for test driven development but not so good for ensuring the default branch is in a releasable state.

It is odd that the Windows runner in the test matrix ran and failed somewhat quickly but the Linux and macOS runners are both still running (hung state?), spinning on this new job step.

@cd-work
Copy link
Contributor Author

cd-work commented May 24, 2022

Merging these changes will introduce failing tests to CI...which is good for test driven development but not so good for ensuring the default branch is in a releasable state.

I did not expect so many tests to fail, but I've fixed all of them in separate commits.

@cd-work
Copy link
Contributor Author

cd-work commented May 24, 2022

It is odd that the Windows runner in the test matrix ran and failed somewhat quickly but the Linux and macOS runners are both still running (hung state?), spinning on this new job step.

Because Windows runs into a stack overflow.

maxrake
maxrake previously approved these changes May 26, 2022
mathew-horner
mathew-horner previously approved these changes May 26, 2022
@cd-work cd-work dismissed stale reviews from mathew-horner and maxrake via 857ae61 May 30, 2022 16:48
@cd-work cd-work force-pushed the 1984 branch 4 times, most recently from 285c4a6 to ecfa0cb Compare May 30, 2022 18:22
cd-work added 5 commits May 30, 2022 20:22
This is a regression introduced in d7778c1, which changed the subcommand
parser to look for `extensions`, instead of the clap-defined
`extension`.
This fixes the test for executing extensions and now successfully
verifies the output of the sample-extension.
This removes some integration testing attempts which were out of date
with the current phylum executable and failing because of it.
This adds a separate test step for all available features, to ensure
that the current WIP development features also build without any issue.
@cd-work cd-work requested a review from kylewillmon May 30, 2022 18:37
@cd-work cd-work merged commit e91f00a into main May 31, 2022
@cd-work cd-work deleted the 1984 branch May 31, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests for running extensions

4 participants