Add CI test for Rust features

.github/workflows/test.yml

@@ -58,6 +58,12 @@ jobs:
           command: test
           args: --locked
 
+      - name: All Features
+        uses: actions-rs/cargo@v1
+        with:
+          command: test
+          args: --all-features
+
   # This job reports the results of the test matrix above
   test:
     if: always()

cli/Cargo.toml

@@ -7,7 +7,6 @@ rust-version = "1.60"
 
 [features]
 default = ["selfmanage"]
-phylum-online = []
 selfmanage = []
 extensions = ["dep:deno_ast", "dep:deno_core"]
 

cli/src/bin/phylum.rs

@@ -199,7 +199,7 @@ async fn handle_commands() -> CommandResult {
         "uninstall" => handle_uninstall(matches),
 
         #[cfg(feature = "extensions")]
-        "extensions" => handle_extensions(matches).await,
+        "extension" => handle_extensions(matches).await,
 
         #[cfg(feature = "extensions")]
         extension_subcmd => Extension::load(extension_subcmd)?.run().await,

cli/tests/extensions.rs

@@ -64,17 +64,13 @@ fn can_run_installed_extension() {
         .assert()
         .success();
 
-    let cmd = Command::cargo_bin("phylum")
+    Command::cargo_bin("phylum")
         .unwrap()
         .env("XDG_DATA_HOME", &tmp_dir)
         .arg("sample-extension")
         .assert()
-        .success();
-
-    // TODO match the output of the sample extension to ensure it executed properly. #357
-    // TODO build a proper fixture which prints some output.
-    let output = std::str::from_utf8(&cmd.get_output().stdout).unwrap();
-    println!("{}", output);
+        .success()
+        .stdout("Hello, World!\n");
 }
 
 // When a user installs a valid extension it should print a message indicating

cli/tests/fixtures/extensions/ping-extension/PhylumExt.toml

@@ -1,3 +1,3 @@
 name = "ping"
 description = "This extension should be filtered out"
-entry_point = "sample_extension.sh"
+entry_point = "main.ts"

cli/tests/fixtures/extensions/ping-extension/main.ts

@@ -0,0 +1 @@
+Deno.core.print("Hello, world!\n");

cli/tests/fixtures/extensions/sample-extension/PhylumExt.toml

@@ -1,3 +1,3 @@
 name = "sample-extension"
 description = "This extension does a thing"
-entry_point = "sample_extension.sh"
+entry_point = "main.ts"

cli/tests/fixtures/extensions/sample-extension/main.ts

@@ -0,0 +1 @@
+Deno.core.print("Hello, World!\n");