Allow is_subclass_of with second parameter of type class-string

[romm]

The following code should not report an error anymore:

class SomeClass
{
	/**
	 * @param class-string $classString
	 */
	public function foo(string $classString): bool
	{
		return is_subclass_of(DateTimeInterface::class, $classString);
	}

	/**
	 * @param class-string<object> $classString
	 */
	public function bar(string $classString): bool
	{
		return is_subclass_of(DateTimeInterface::class, $classString);
	}
}

But this one will still report an error:

class SomeClass
{
	/**
	 * @param class-string<DateTimeInterface> $classString
	 */
	public function foo(string $classString): bool
	{
		return is_subclass_of(DateTimeInterface::class, $classString);
	}
}

Closes phpstan/phpstan#2755

[staabm]

both mentioned cases of the PR description seem to be fixed

https://phpstan.org/r/f10c4833-22f6-4836-a2df-d6fd9cd822b1
https://phpstan.org/r/f97e613a-d4e9-49ff-b92a-3220717702e2

I guess this can be closed.

@romm could you confirm?

[staabm]

looking at the example in phpstan/phpstan#2755 which this PR is trying to fix, it seems there is still a issue though..?

[enumag]

Yeah, my original issue isn't fixed yet. I'm not sure if this PR would fix it though since that case isn't in the tests.

[ondrejmirtes]

/cc @staabm Could we achieve this the same way as with is_a in #1311 ?

[staabm]

@ondrejmirtes I fixed the origin problem with #1321

this PR here as is does no longer fix a real issue and can be closed IMO

[ondrejmirtes]

Okay :)