improve is_subclass_of type checks #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
May 16, 2022
| @@ -2,7 +2,15 @@ | |||
|
|
|||
| /** | |||
| * @param ($allow_string is false ? object : object|string) $object_or_class | |||
| * @param class-string $class | |||
There was a problem hiding this comment.
changed both, is_a and is_subclass_of $class arg back to string for max compat with 1.6.x
staabm
commented
May 16, 2022
| @@ -42,6 +43,11 @@ public function specifyTypes(FunctionReflection $functionReflection, FuncCall $n | |||
| $allowStringType = isset($node->getArgs()[2]) ? $scope->getType($node->getArgs()[2]->value) : new ConstantBooleanType(true); | |||
| $allowString = !$allowStringType->equals(new ConstantBooleanType(false)); | |||
|
|
|||
| // prevent false-positives in IsAFunctionTypeSpecifyingHelper | |||
| if ($objectOrClassType instanceof GenericClassStringType && $classType instanceof GenericClassStringType) { | |||
There was a problem hiding this comment.
obviously this is not a great fix, but with this PR we fix the existing/reported false-positives.
proper support for generic-class-string in is_subclass_of could be added later.. since there are not existing tests for this case, this should be fine for now
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#2755