Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use conditional parameter for is_a() via stub #1311

Merged
merged 9 commits into from
May 13, 2022
Merged

use conditional parameter for is_a() via stub #1311

merged 9 commits into from
May 13, 2022

Conversation

staabm
Copy link
Contributor

@staabm staabm commented May 13, 2022 •
edited
Loading

is_a: if third argument is false then do not allow string in first argument

refs phpstan/phpstan#4371

@staabm
Copy link
Contributor Author

staabm commented May 13, 2022

remaining errors are caused by the more strict parameter type

@staabm staabm marked this pull request as ready for review May 13, 2022 14:21
@ondrejmirtes
Copy link
Member

What about string instead of class-string? That preserves the previous behaviour.

@staabm
Copy link
Contributor Author

staabm commented May 13, 2022

What about string instead of class-string?

I am fine with that.

@ondrejmirtes ondrejmirtes merged commit 9d9dcd8 into phpstan:1.7.x May 13, 2022
@ondrejmirtes
Copy link
Member

Thank you!

@ondrejmirtes ondrejmirtes mentioned this pull request May 13, 2022
Closed
@staabm staabm deleted the cond-is-a-param branch May 13, 2022 14:48
This was referenced May 15, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@staabm @ondrejmirtes @clxmstaab