Remove superfluous determination of cURL version #16787
Conversation
This was originally meant to distinguish between libcurl 7.59.0 and earlier; only the latter would need to be linked against normalize.lib, libssh2.lib and nghttp2.lib[1]. That would only have catered to our builds, and might not have been correct anyway. However, the version check was wrong (paren error), and has been removed in the meantime[2]. Given that cURL 7.59.0 is rather old, we do not reinstate the version check, but rather drop the now superfluous (and improper) determination of the cURL version. A nice bonus is that we get rid of some global variables. [1] <php@a1ba300> [2] <php@94a12d5>
There was a problem hiding this comment.
@cmb69 even if this should be added back with the correct paren, the 0x073b00 version is 7.59
The minimum required Curl version as of PHP 8.4 is 7.61. So, I'm not sure what should be added back here as noted in the comment on the PR. That removal was correct in any case. Yes?
If curl version won't be checked on Windows, then also this can be then removed.
Oh, indeed! I've missed that PHP 8.4 already requires cURL >= 7.61.0.
Checking the required version on Windows would be good (although not super important), but that should either use |
This was originally meant to distinguish between libcurl 7.59.0 and earlier; only the latter would need to be linked against normalize.lib, libssh2.lib and nghttp2.lib[1]. That would only have catered to our builds, and might not have been correct anyway. However, the version check was wrong (paren error), and has been removed in the meantime[2].
Given that cURL 7.59.0 is rather old, we do not reinstate the version check, but rather drop the now superfluous (and improper) determination of the cURL version. A nice bonus is that we get rid of some global variables.
[1] a1ba300
[2] 94a12d5