ext/curl: Cleanup config.w32 to remove superfluous checks and outdated comments
#13684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted comments - Remove a check for an always-true curl version check - Remove a `TODO` comment for curl_version_info check that should be always available since libcurl 7.10
cmb69
reviewed
Nov 13, 2024
Comment on lines
-24
to
-27
| (ver_num <= parseInt("0x073b00") || ver_num > parseInt("0x073b00") && | ||
| CHECK_LIB("normaliz.lib", "curl", PHP_CURL) && | ||
| CHECK_LIB("libssh2.lib", "curl", PHP_CURL) && | ||
| CHECK_LIB("nghttp2.lib", "curl", PHP_CURL)) |
There was a problem hiding this comment.
That was supposed to be:
(ver_num <= parseInt("0x073b00")) || (ver_num > parseInt("0x073b00") &&
CHECK_LIB("normaliz.lib", "curl", PHP_CURL) &&
CHECK_LIB("libssh2.lib", "curl", PHP_CURL) &&
CHECK_LIB("nghttp2.lib", "curl", PHP_CURL))
But see #16787 for why I agree that dropping the check is fine.
There was a problem hiding this comment.
I see. Ok. Yes, there was also a comment about this change on the initial commit but never got addressed back then in 2018. Then fine to be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOcomment for curl_version_info check that should be always available since libcurl 7.10