Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous determination of cURL version #16787

Merged
merged 1 commit into from
Nov 14, 2024

Commits on Nov 13, 2024

  1. Remove superfluous determination of cURL version

    This was originally meant to distinguish between libcurl 7.59.0 and
    earlier; only the latter would need to be linked against normalize.lib,
    libssh2.lib and nghttp2.lib[1].  That would only have catered to our
    builds, and might not have been correct anyway.  However, the version
    check was wrong (paren error), and has been removed in the meantime[2].
    
    Given that cURL 7.59.0 is rather old, we do not reinstate the version
    check, but rather drop the now superfluous (and improper) determination
    of the cURL version.  A nice bonus is that we get rid of some global
    variables.
    
    [1] <php@a1ba300>
    [2] <php@94a12d5>
    cmb69 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    3d075d6 View commit details
    Browse the repository at this point in the history