-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RC Test: Circuit Construction Kit: DC & DC "Virtual Lab" 1.2.0-rc.2 #610
Comments
I listed the issues above. I briefly spot checked each one except for Android phetsims/circuit-construction-kit-common#670 and I only looked at one of the screenshots in phetsims/circuit-construction-kit-common#665 |
Platforms:
|
I think it could be sufficient to test each of the issues one on platform each (as long as you test on a platform that exhibited the problem in RC.1). |
QA is done |
@arouinfar can you please review the issues and let me know if they should block publication? |
BTW checked RC on android app on tablet, and it seems to work there. |
The only potentially blocking issue is phetsims/circuit-construction-kit-common#673, but I can't make a call without being able to judge the severity of the issue. |
We determined that phetsims/circuit-construction-kit-common#673 is non-blocking, so I'll close this issue and work towards publishing a production version. |
Perhaps I'll use this issue for the publication steps before moving it to the "published" column. |
I asked @KatieWoe on slack if the QA credits are up-to-date. |
@KatieWoe reported:
|
|
I published the 1.2 versions of the sims. @arouinfar do we need to update metadata on the website? @oliver-phet and @arouinfar discussed that we may need to reach out to clients or people that have written in to phethelp. Please feel free to open a separate issue as appropriate. |
@samreid I've updated the Teacher Tips and website metadata. Announcement email will be tracked in phetsims/tasks#1078, closing. |
RC1 completed in #605. The issues to be confirmed are listed as "ready for qa" in https://github.com/phetsims/circuit-construction-kit-common/milestone/1, I will list them below as a record. When an issue has been confirmed, it can be closed. When all issues are closed, the sim is ready for production.
The deploy links are:
https://phet-dev.colorado.edu/html/circuit-construction-kit-dc/1.2.0-rc.2/phet/circuit-construction-kit-dc_en_phet.html
https://phet-dev.colorado.edu/html/circuit-construction-kit-dc-virtual-lab/1.2.0-rc.2/phet/circuit-construction-kit-dc-virtual-lab_en_phet.html
I placed this directly in "Active Tests" since it had a high priority in RC1, and the Active Tests (max 5) only had 4 things in it at the moment. Priority should be assigned by @kathy-phet and/or @KatieWoe, but I think this will be a very quick spot check.
The text was updated successfully, but these errors were encountered: