Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC Test: Circuit Construction Kit: DC & DC "Virtual Lab" 1.2.0-rc.2 #610

Closed
samreid opened this issue Feb 17, 2021 · 15 comments
Closed

RC Test: Circuit Construction Kit: DC & DC "Virtual Lab" 1.2.0-rc.2 #610

samreid opened this issue Feb 17, 2021 · 15 comments
Assignees
Labels
priority:2-high QA:published When a completed test leads to publication, it is marked as published, so we can see them in a list QA:rc-spot-check QA:rc-test

Comments

@samreid
Copy link
Member

samreid commented Feb 17, 2021

RC1 completed in #605. The issues to be confirmed are listed as "ready for qa" in https://github.com/phetsims/circuit-construction-kit-common/milestone/1, I will list them below as a record. When an issue has been confirmed, it can be closed. When all issues are closed, the sim is ready for production.

The deploy links are:
https://phet-dev.colorado.edu/html/circuit-construction-kit-dc/1.2.0-rc.2/phet/circuit-construction-kit-dc_en_phet.html
https://phet-dev.colorado.edu/html/circuit-construction-kit-dc-virtual-lab/1.2.0-rc.2/phet/circuit-construction-kit-dc-virtual-lab_en_phet.html

I placed this directly in "Active Tests" since it had a high priority in RC1, and the Active Tests (max 5) only had 4 things in it at the moment. Priority should be assigned by @kathy-phet and/or @KatieWoe, but I think this will be a very quick spot check.

@samreid
Copy link
Member Author

samreid commented Feb 17, 2021

I listed the issues above. I briefly spot checked each one except for Android phetsims/circuit-construction-kit-common#670 and I only looked at one of the screenshots in phetsims/circuit-construction-kit-common#665

@samreid samreid changed the title RC Test: Circuit Construction Kit: DC & DC "Virtual Lab" 1.2.0-rc.1 RC Test: Circuit Construction Kit: DC & DC "Virtual Lab" 1.2.0-rc.2 Feb 17, 2021
@samreid samreid assigned kathy-phet and KatieWoe and unassigned samreid Feb 17, 2021
@KatieWoe
Copy link
Contributor

KatieWoe commented Feb 17, 2021

Platforms:

  • Win 10 Chrome (Time = 4h)
  • Win 10 Firefox (Time = 2.5h)
  • MacOS 11 Safari (Time = 1.5h )
  • iPadOS 14 Safari (Time = 1 hour)
  • ChromeOS (Time = 10 min)

@samreid
Copy link
Member Author

samreid commented Feb 17, 2021

I think it could be sufficient to test each of the issues one on platform each (as long as you test on a platform that exhibited the problem in RC.1).

@KatieWoe
Copy link
Contributor

QA is done

@KatieWoe KatieWoe assigned samreid and unassigned KatieWoe Feb 22, 2021
@samreid
Copy link
Member Author

samreid commented Feb 23, 2021

@arouinfar can you please review the issues and let me know if they should block publication?

@KatieWoe
Copy link
Contributor

BTW checked RC on android app on tablet, and it seems to work there.

@arouinfar
Copy link
Contributor

The only potentially blocking issue is phetsims/circuit-construction-kit-common#673, but I can't make a call without being able to judge the severity of the issue.

@arouinfar arouinfar removed their assignment Feb 24, 2021
@samreid
Copy link
Member Author

samreid commented Feb 24, 2021

We determined that phetsims/circuit-construction-kit-common#673 is non-blocking, so I'll close this issue and work towards publishing a production version.

@samreid samreid closed this as completed Feb 24, 2021
@samreid samreid reopened this Feb 24, 2021
@samreid
Copy link
Member Author

samreid commented Feb 24, 2021

Perhaps I'll use this issue for the publication steps before moving it to the "published" column.

@samreid
Copy link
Member Author

samreid commented Feb 24, 2021

I asked @KatieWoe on slack if the QA credits are up-to-date.

@samreid
Copy link
Member Author

samreid commented Feb 24, 2021

@KatieWoe reported:

add Brooklyn Lash, Megan Lai, Matthew Moore, and Devon Quispe

samreid added a commit to phetsims/circuit-construction-kit-dc that referenced this issue Feb 24, 2021
samreid added a commit to phetsims/circuit-construction-kit-dc that referenced this issue Feb 24, 2021
samreid added a commit to phetsims/circuit-construction-kit-dc-virtual-lab that referenced this issue Feb 24, 2021
samreid added a commit to phetsims/circuit-construction-kit-dc-virtual-lab that referenced this issue Feb 24, 2021
@samreid
Copy link
Member Author

samreid commented Feb 25, 2021

Deployed: https://phet.colorado.edu/sims/html/circuit-construction-kit-dc/latest/circuit-construction-kit-dc_en.html
Please wait for the build-server to complete the deployment, and then test!
After testing, let the simulation lead know it has been deployed, so they can edit metadata on the website

@samreid
Copy link
Member Author

samreid commented Feb 25, 2021

I published the 1.2 versions of the sims. @arouinfar do we need to update metadata on the website?

@oliver-phet and @arouinfar discussed that we may need to reach out to clients or people that have written in to phethelp. Please feel free to open a separate issue as appropriate.

@arouinfar
Copy link
Contributor

@samreid I've updated the Teacher Tips and website metadata. Announcement email will be tracked in phetsims/tasks#1078, closing.

@samreid samreid added the QA:published When a completed test leads to publication, it is marked as published, so we can see them in a list label Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:2-high QA:published When a completed test leads to publication, it is marked as published, so we can see them in a list QA:rc-spot-check QA:rc-test
Projects
Status: Done
Development

No branches or pull requests

5 participants