Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Memory Leak #660

Closed
KatieWoe opened this issue Feb 10, 2021 · 8 comments
Closed

Possible Memory Leak #660

KatieWoe opened this issue Feb 10, 2021 · 8 comments

Comments

@KatieWoe
Copy link
Contributor

For phetsims/qa#605. Done on Win 10 Chrome with CCK DC sim.
Start: 25.3
1 min: 111
2 min: 152
3 min: 192
4 min: 218
5 min: 242
6 min: 251
7 min: 227
8 min: console crashed.

I also noticed that, while fuzz testing for this memory test, sometimes the electrons would appear to be floating free of the objects. Not sure how to achieve this without fuzz testing.
leftbehindmemtest

@KatieWoe
Copy link
Contributor Author

For comparison, here are the results from the published sim:
Start: 16.6
1 min: 33.8
2 min: 40.9
3 min: 68
4 min: 64.5
5 min: 39.4
6 min: 37.8
7 min: 56
8 min: 34.5
9 min: 32.8
10 min: 29

I also didn't notice the electron behavior from above

@samreid
Copy link
Member

samreid commented Feb 13, 2021

Thanks for finding this new problem, I corrected it on my side and ran a test over about 15 minutes:
image

I'll commit shortly.

@samreid
Copy link
Member

samreid commented Feb 13, 2021

To try to make the tests more reproducible, I tried to press "Reset All" on both screens before capturing the memory snapshot--to try to avoid noise. @KatieWoe can you please test on one platform in master? If it seems good, please reassign to me and I'll cherry pick it into the RC.

@KatieWoe
Copy link
Contributor Author

Here is my new memory test from master. It looks better:
newmemtest
@samreid I did still see the odd electron behavior. Should this get it's own issue, or is it not worth an issue?
electrons

@samreid
Copy link
Member

samreid commented Feb 16, 2021

I opened a new issue for the electrons getting disassociated..

samreid added a commit to phetsims/circuit-construction-kit-dc that referenced this issue Feb 16, 2021
samreid added a commit to phetsims/circuit-construction-kit-dc-virtual-lab that referenced this issue Feb 16, 2021
@samreid
Copy link
Member

samreid commented Feb 17, 2021

This is ready for spot checking in the deployments listed for phetsims/qa#610, please close if it seems correct in RC.2.

@KatieWoe
Copy link
Contributor Author

DC memory test:
maybefixedmemtest
VL memory test:
VLmemtest
@samreid if these are expected numbers, please close.

@samreid
Copy link
Member

samreid commented Feb 19, 2021

That seems much better, thanks! Closing.

@samreid samreid closed this as completed Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants