Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC Test: Circuit Construction Kit: DC & DC "Virtual Lab" 1.2.0-rc.1 #605

Closed
1 of 2 tasks
samreid opened this issue Feb 3, 2021 · 9 comments
Closed
1 of 2 tasks
Assignees

Comments

@samreid
Copy link
Member

samreid commented Feb 3, 2021

@arouinfar @kathy-phet @KatieWoe, circuit-construction-kit-dc/1.2.0-rc.1 and circuit-construction-kit-dc-virtual-lab/1.2.0-rc.1 are ready for RC testing.

@kathy-phet said:

Teachers are head-over-heals for this non-ohmic bulb and if we get it out soon, it would be used immediately. So this is a priority and I'd like to see it move to rc quickly if possible.
[...] This is higher priority than GAO.

Document issues in https://github.com/phetsims/circuit-construction-kit-common/issues and link to this
issue.

Prior dev testing completed in #587
The publication issue is phetsims/circuit-construction-kit-common#616

Assigning to @kathy-phet or @KatieWoe for prioritization.

General RC Test

What to Test

  • Click every single button.
  • Test all possible forms of input.
    • Test all mouse/trackpad inputs.
    • Test all touchscreen inputs.
  • If there is sound, make sure it works.
  • Make sure you can't lose anything.
  • Play with the sim normally.
  • Try to break the sim.
  • Test all query parameters on all platforms. (See QA Book
    for a list of query parameters.)
  • Download HTML on Chrome and iOS.
  • Make sure the iFrame version of the simulation is working as intended on all platforms.
  • Make sure the XHTML version of the simulation is working as intended on all platforms.
  • Complete the test matrix.
  • Don't forget to make sure the sim works with Legends of Learning.
  • Test the Game Up harness on at least one platform.
  • Check this LoL
    spreadsheet and notify AR or AM if it not there.
  • If this is rc.1 please do a memory test.
  • When making an issue, check to see if it was in a previously published version
  • Try to include version numbers for browsers
  • If there is a console available, check for errors and include them in the Problem Description.
  • As an RC begins and ends, check the sim repo. If there is a maintenance issue, check it and notify developers if
    there is a problem.

Focus and Special Instructions

[Provide further instructions here. If you have any further tests you want done or specific platforms you want tested,
list them here. Any behaviors you want QA to pay special attention to should be listed here.]

Issues to Verify

These issues should have the "status:ready-for-qa" label. Check these issues off and close them if they are fixed.
Otherwise, post a comment in the issue saying that it wasn't fixed and link back to this issue. If the label is
"status:ready-for-review" or "status:fixed-pending-deploy" then assign back to the developer when done, even if fixed.

Link(s)

CCK DC

CCK DC Virtual Lab (just needs a spot check, since it is 99% same as CCK DC)


Accessibility (a11y) RC Test

What to Test

  • Specific instructions can be found below.
  • Make sure the a11y feature doesn't negatively affect the sim in any way.
  • You should be able to use the delete key to delete a selected circuit element
  • Keyboard navigation is not supported
  • Screen readers are not supported

Magnification

This sim supports magnification with pinch and drag gestures on touch screens, keyboard shortcuts, and mouse/wheel controls. Please test magnfication and make sure
it is working as intended and well with the use cases of the simulation. Due to the way screen readers handle user input, magnification is NOT expected to
work while using a screen reader so there is no need to test this case.

Final Requests


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@samreid
Copy link
Member Author

samreid commented Feb 3, 2021

I set priority to "high" and moved it above "Gravity and Orbits" in the Project Board, please adjust as necessary.

@samreid
Copy link
Member Author

samreid commented Feb 4, 2021

@jessegreenberg said there is a joist bug that affects the home screen. We would likely invalidate this RC and take new SHAs once that's corrected.

@jessegreenberg
Copy link
Contributor

Sorry @samreid, the regression identified in phetsims/joist#658 (comment) made it to this RC. This reverting commit in joist should be cherry-picked into the joist code for this RC. phetsims/joist@d0be22a

@samreid
Copy link
Member Author

samreid commented Feb 4, 2021

We would likely invalidate this RC and take new SHAs once that's corrected.

@KatieWoe if you have a chance to start testing before I publish new versions, I think that's OK. Let's just consider phetsims/joist@d0be22a as something to be cherry-picked before publication.

@KatieWoe
Copy link
Contributor

Noting that this sim should be added to the LoL spreadsheet when it is ready.

@arouinfar
Copy link
Contributor

These sims have already been delivered to LoL. Since the client uses the "latest" version of the sim, they won't need to manually update anything. The changes are not significant enough to warrant new icons/descriptions.

@KatieWoe
Copy link
Contributor

QA is done.

@KatieWoe KatieWoe assigned samreid and unassigned KatieWoe Feb 11, 2021
@jessegreenberg
Copy link
Contributor

@samreid @KatieWoe CCK DC and CCK DC Virtual Lab 1.2 scenery SHAs received a patch for phetsims/phet-android-app#155.

If possible, you may wish to verify this sim works well in the PhET Android app as part of this test or the next one if there is one.

@samreid
Copy link
Member Author

samreid commented Feb 12, 2021

Thanks, I reviewed the opened issues and will continue there. Nice discoveries and thanks!

@samreid samreid closed this as completed Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants