Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry picks for the 1.2 release of DC and DC Virtual Lab #667

Closed
samreid opened this issue Feb 16, 2021 · 5 comments
Closed

Cherry picks for the 1.2 release of DC and DC Virtual Lab #667

samreid opened this issue Feb 16, 2021 · 5 comments

Comments

@samreid
Copy link
Member

samreid commented Feb 16, 2021

Here are the commits to cherry pick for the upcoming 1.2 release:

2753793
1dcefb6
24888bc
phetsims/circuit-construction-kit-dc-virtual-lab@e64b792
62d1650

@samreid samreid self-assigned this Feb 16, 2021
@arouinfar
Copy link
Contributor

@samreid can you add phetsims/joist@991d6a4 to the list? There are joist sounds in the latest rc, which is odd because all other UI sounds are disabled, see phetsims/joist#680.

@samreid
Copy link
Member Author

samreid commented Feb 16, 2021

Summarizing other patches that should be in this release:

Other patches that should already be in the branches:

  • @samreid @KatieWoe CCK DC and CCK DC Virtual Lab 1.2 scenery SHAs received a patch for phetsims/phet-android-app#155

@samreid
Copy link
Member Author

samreid commented Feb 16, 2021

I applied patches for all of the above, but @jonathanolson recommended we coordinate with @jessegreenberg about the others before publishing the next RC.

@samreid
Copy link
Member Author

samreid commented Feb 16, 2021

I applied patches for all of the above, but @jonathanolson recommended we coordinate with @jessegreenberg about the others before publishing the next RC.

@pixelzoom indicated that phetsims/joist#680 only affects CCK sims, so I went ahead and patched it. Afterwards, I realized that it made commits to a branch in joist. Hopefully this doesn't disrupt ongoing maintenance releases. Oh, next I realized that the fix for https://github.com/phetsims/phet-android-app/issues/155 was a scenery commit. I checked that fix was in both scenery branches. So maybe since it was separate repos they wont interfere.

@samreid
Copy link
Member Author

samreid commented Feb 17, 2021

I'll track the rest of the work in separate issues, closing.

@samreid samreid closed this as completed Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants