Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in Africa/ Modest, Asia, Oceania, and Latin America character sets #304

Open
amanda-phet opened this issue Dec 15, 2023 · 8 comments
Open

Comments

@amanda-phet
Copy link
Contributor

No description provided.

@Luisav1
Copy link
Contributor

Luisav1 commented Jan 26, 2024

The preferences model and structure for portrayals is added in and FAMB is ready for the artwork @amanda-phet.

@amanda-phet
Copy link
Contributor Author

New USA set (in svg) is ready to try out. I gave these to @Luisav1 on slack, but will put here for posterity. If these work out, I will move ahead with exporting the other regions (which are all drawn and resized, but there will be some more steps before they are ready for export)

usaGirlHolding
usaGirlSitting
usaGirlStanding
usaManHolding
usaManSitting
usaManStanding

Luisav1 added a commit that referenced this issue Jul 31, 2024
amanda-phet added a commit that referenced this issue Aug 1, 2024
amanda-phet added a commit that referenced this issue Aug 1, 2024
amanda-phet added a commit that referenced this issue Aug 1, 2024
amanda-phet added a commit that referenced this issue Aug 1, 2024
amanda-phet added a commit that referenced this issue Aug 1, 2024
@amanda-phet
Copy link
Contributor Author

These are looking good!

Should we be including "Africa (modest)" in the list of regions if there isn't a separate set of people for that region?

@amanda-phet amanda-phet assigned Luisav1 and unassigned amanda-phet Aug 21, 2024
@amanda-phet amanda-phet assigned amanda-phet and unassigned Luisav1 Sep 24, 2024
@amanda-phet
Copy link
Contributor Author

I will ask about this in the region and culture channel!

@amanda-phet
Copy link
Contributor Author

Let's go ahead and remove Africa (Modest) from the preferences dropdown.

@amanda-phet amanda-phet assigned samreid and unassigned amanda-phet Sep 25, 2024
samreid added a commit that referenced this issue Oct 1, 2024
@samreid
Copy link
Member

samreid commented Oct 1, 2024

I removed Africa (modest) in the commit. @amanda-phet can you please review/test and summarize what changes remain for this issue?

@kathy-phet
Copy link

In recent client meetings, it was again found that clients using products in particular regions value the positive affirmation that a character set is "modest". So we should keep Africa (modest) setting as an option, even if at the moment it is just a duplicate of the Africa setting.

@samreid - Can you please revert the removal of this option, Sam?

@samreid samreid self-assigned this Oct 19, 2024
samreid added a commit that referenced this issue Oct 21, 2024
@samreid
Copy link
Member

samreid commented Oct 21, 2024

I reverted the removal and tested that it worked OK at runtime.

@samreid samreid removed their assignment Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants