-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use TimeControlNode for Play/Pause/Step buttons #280
Comments
The API for StepButton changed and isPlayingProperty was replaced with enabledProperty. When TimeControlNode is used in this sim the setting of enabledProperty can be removed because it is the default behavior for TimeControlNode. |
This seems like something that could be addressed with #304 |
Addressed in the above commit. However, there is currently a slightly different behavior: When you pause the sim in the published version, the play/pause button changes scales and becomes bigger. This is not present in the TimeControlNode component and I wouldn't know how if there's currently an easy way of implementing, nor it would be consistent with other sims. Assigning back to @amanda-phet to chime in on this and close if done |
This caused some PhET-iO validation trouble, but FAMB isn't active in its phet-io implementation, so let's turn off validation until we work on PhET-iO again. |
I think the custom resizing is unnecessary and using a common component is more important. This looks good to me. |
From phetsims/scenery-phet#561. A scenery-phet/TimeControlNode was created that combines the PlayPauseButton and StepForwardButton and includes PhET-iO and PDOM instrumentation. It should be used in this sim. Assigning to responsible dev.
The text was updated successfully, but these errors were encountered: