Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TimeControlNode for Play/Pause/Step buttons #280

Closed
jessegreenberg opened this issue Dec 11, 2019 · 5 comments
Closed

Use TimeControlNode for Play/Pause/Step buttons #280

jessegreenberg opened this issue Dec 11, 2019 · 5 comments
Assignees

Comments

@jessegreenberg
Copy link
Contributor

From phetsims/scenery-phet#561. A scenery-phet/TimeControlNode was created that combines the PlayPauseButton and StepForwardButton and includes PhET-iO and PDOM instrumentation. It should be used in this sim. Assigning to responsible dev.

@jessegreenberg
Copy link
Contributor Author

The API for StepButton changed and isPlayingProperty was replaced with enabledProperty. When TimeControlNode is used in this sim the setting of enabledProperty can be removed because it is the default behavior for TimeControlNode.

@amanda-phet
Copy link
Contributor

This seems like something that could be addressed with #304

@AgustinVallejo
Copy link
Contributor

Addressed in the above commit. However, there is currently a slightly different behavior: When you pause the sim in the published version, the play/pause button changes scales and becomes bigger. This is not present in the TimeControlNode component and I wouldn't know how if there's currently an easy way of implementing, nor it would be consistent with other sims.

Assigning back to @amanda-phet to chime in on this and close if done

@zepumph
Copy link
Member

zepumph commented Jan 16, 2024

This caused some PhET-iO validation trouble, but FAMB isn't active in its phet-io implementation, so let's turn off validation until we work on PhET-iO again.

@amanda-phet
Copy link
Contributor

When you pause the sim in the published version, the play/pause button changes scales and becomes bigger. This is not present in the TimeControlNode component and I wouldn't know how if there's currently an easy way of implementing, nor it would be consistent with other sims.

I think the custom resizing is unnecessary and using a common component is more important. This looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants