-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCK: Basic PhET-iO instrumentation #589
Comments
I published a version here but noticed not all of the requests are "featured". https://phet-dev.colorado.edu/html/circuit-construction-kit-dc/1.2.0-dev.3/phet-io/ I think I should make those requests featured and post a new version. |
Here's a dev version that features the items above: I did some basic testing on save/loading circuits and didn't see any obvious problems. |
I'll work on turning off the common code sound effects in #562. @kathy-phet what level of testing or QA do you want to complete before delivering this to the client? |
I disabled the common code sound effects and published a new dev version here: |
@kathy-phet and @arouinfar reported they will be reviewing this today. I ran through the UPDATE: I noticed that if you hide the resistor from the carousel, then drag something else, the resistor reappears in the toolbox. I'll investigate. UPDATE: I posted a version here which is a little better: In this version, dragging out other components or resetting doesn't restore the resistor tool. But dragging the resistor tool to to the toolbox restores it. I'll wait for guidance on how to proceed here, but here are some options:
|
@kathy-phet indicated her and @arouinfar work will resume on this early December. |
This has been prioritized for the upcoming quarter. We may work on some design work, but implementation work will wait until after AC 1.0 is published. I'd also like to move to TypeScript before doing the phet-io instrumentation. |
UPDATE: I moved this comment to #513 (comment) |
Since we are moving forward with the full phet-io instrumentation (instead of this "basic" version), I opened side issues for the remaining work and will close this one. |
We would like to add basic PhET-iO instrumentation for a client.
Use
circuitConstructionKitDc.introScreen.view.circuitElementToolbox.carousel.tools.resistorToolNode.visibleProperty
. Note, it does not reflow the layout.Use
circuitConstructionKitDc.introScreen.view.sensorToolbox.visibleProperty
to hide both.Use
circuitConstructionKitDc.introScreen.view.sensorToolbox.ammeterToolIconWithLabel.visibleProperty
to hide the ammeter(s)Use
circuitConstructionKitDc.introScreen.view.sensorToolbox.voltmeterToolIconWithLabel.visibleProperty
to hide the voltmeter.NOTE: If you use both of the latter 2, it will throw an assertion error related to bounds in the debug version, but not in the built version.
Use
circuitConstructionKitDc.introScreen.model.ammeter1.visibleProperty
.Use
circuitConstructionKitDc.introScreen.model.circuit.showCurrentProperty
Use
circuitConstructionKitDc.introScreen.view.displayOptionsPanel.showCurrentCheckbox.visibleProperty
but note the radio buttons below remain visible.The reset button can be hidden with
circuitConstructionKitDc.introScreen.view.resetAllButton.visibleProperty
.Use
circuitConstructionKitDc.general.view.navigationBar.phetButton.enabledProperty
I'll work on this for the DC simulation.
The text was updated successfully, but these errors were encountered: