Skip to content

Commit

Permalink
Fix phet-io validation issues, see #589
Browse files Browse the repository at this point in the history
  • Loading branch information
samreid committed Jul 22, 2020
1 parent 91c9114 commit bb5ec31
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
5 changes: 3 additions & 2 deletions js/model/CircuitConstructionKitModel.js
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ class CircuitConstructionKitModel {

// True if the simulation is playing, controlled by the TimeControlNode
this.isPlayingProperty = new BooleanProperty( true, {
tandem: tandem.createTandem( 'isPlayingProperty' )
tandem: tandem.createTandem( 'isPlayingProperty' ),
phetioFeatured: true
} );

// @public {Property.<InteractionMode>} - whether the user is in the CircuitConstructionKitModel.InteractionMode.EXPLORE or CircuitConstructionKitModel.InteractionMode.TEST mode
Expand Down Expand Up @@ -135,7 +136,7 @@ class CircuitConstructionKitModel {
this.isValueDepictionEnabledProperty.value = false;
}
};
this.circuit.vertexGroup.elementCreatedEmitter.addListener( pause );
this.circuit.vertexGroup.elementCreatedEmitter.addListener( pause );
this.circuit.vertexGroup.elementDisposedEmitter.addListener( pause );
this.circuit.componentEditedEmitter.addListener( pause );
this.circuit.circuitElements.lengthProperty.link( pause );
Expand Down
2 changes: 1 addition & 1 deletion js/model/VoltageSource.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class VoltageSource extends FixedCircuitElement {
isFlammable: true,
numberOfDecimalPlaces: 1,
voltagePropertyOptions: {
tandem: tandem.createTandem( 'voltageProperty' )
tandem: tandem.createTandem( 'voltageSourceProperty' ) // TODO: Collides with Battery.voltageProperty
}
}, options );
super( startVertex, endVertex, length, tandem, options );
Expand Down
1 change: 1 addition & 0 deletions js/view/CCKCScreenView.js
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,7 @@ class CCKCScreenView extends ScreenView {
zoomControlPanel.setScaleMagnitude( 0.8 );

const timeControlNode = new TimeControlNode( model.isPlayingProperty, {
tandem: tandem.createTandem( 'timeControlNode' ),
playPauseStepButtonOptions: {
stepForwardButtonOptions: {
listener: () => model.stepSingleStep()
Expand Down

0 comments on commit bb5ec31

Please sign in to comment.