Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in Africa/ Modest, Asia, Oceania, and Latin America character sets #140

Closed
Luisav1 opened this issue Dec 6, 2023 · 13 comments
Closed

Add in Africa/ Modest, Asia, Oceania, and Latin America character sets #140

Luisav1 opened this issue Dec 6, 2023 · 13 comments
Assignees
@Luisav1
Labels
design:artwork

Comments

@Luisav1
Copy link
Contributor

Luisav1 commented Dec 6, 2023

This sim needs the structure for character sets and a preferences dialog.
@Luisav1 Luisav1 self-assigned this Dec 6, 2023
@amanda-phet
Copy link
Contributor

We'll be using SVGs for all of the characters for this sim.

As part of this work, do we want to update all the the images here to be svg as well? And re-drawn by Mariah?

Luisav1 added a commit that referenced this issue Dec 12, 2023
@Luisav1
Add in structure and a preferences model to set the region and cultur…
13ad65d 
…e portrayal. See #140.
Luisav1 added a commit that referenced this issue Dec 12, 2023
@Luisav1
Correct file imports. See #140.
773c64b
Luisav1 added a commit that referenced this issue Dec 13, 2023
@Luisav1
Add level 3 and 4 icons to portrayals since they have characters too.…
74212fa 
… See #140.
@amanda-phet
Copy link
Contributor

I see that the mipmaps folder is reorganized to allow the new regions, but since these are svg I thought I'd see the folders in /images.

I am thinking we should see /images/usa, etc.

There are a LOT of "objects" in images, though. Should we make a folder for objects? Or should they still live in the root folder?

@Luisav1
Copy link
Contributor Author

Luisav1 commented Dec 14, 2023

I think we could make a folder for objects, leave the screen icons in the root folder, and as well I'll make the regional folders in /images.

Luisav1 added a commit that referenced this issue Dec 14, 2023
@Luisav1
Move all objects artwork files into /objects directory. See #140.
095fa38
Luisav1 added a commit that referenced this issue Dec 14, 2023
@Luisav1
Move defaultImage to /objects. Create regional folders in /images. See …
4d842a7 
…#140.
@Luisav1
Copy link
Contributor Author

Luisav1 commented Dec 14, 2023

@amanda-phet Balancing Act is now ready for the artwork to be uploaded.

@Luisav1 Luisav1 assigned amanda-phet and unassigned Luisav1 Dec 14, 2023
amanda-phet added a commit that referenced this issue Dec 15, 2023
@amanda-phet
Add files via upload
44feb5e 
#140
amanda-phet added a commit that referenced this issue Dec 15, 2023
@amanda-phet
Add files via upload
0a4b730 
#140
amanda-phet added a commit that referenced this issue Dec 15, 2023
@amanda-phet
Add files via upload
00fb4b5 
#140
amanda-phet added a commit that referenced this issue Dec 15, 2023
@amanda-phet
Add files via upload
34d23dd 
#140
amanda-phet added a commit that referenced this issue Dec 15, 2023
@amanda-phet
Add files via upload
f0a5190 
#140
amanda-phet added a commit that referenced this issue Dec 15, 2023
@amanda-phet
Add files via upload
c5cae73 
#140
amanda-phet added a commit that referenced this issue Dec 15, 2023
@amanda-phet
Add files via upload
c7b3e49 
#140
amanda-phet added a commit that referenced this issue Dec 15, 2023
@amanda-phet
Add files via upload
6232d72 
#140
amanda-phet added a commit that referenced this issue Dec 15, 2023
@amanda-phet
Add files via upload
e23fb16 
#140
@amanda-phet
Copy link
Contributor

amanda-phet commented Dec 15, 2023 •
edited
Loading

Thanks for making those folders @Luisav1 !

All of the people are now uploaded. I still need to do the screen icons, but will need the updated objects before I can complete that.

These changes will need to be made to the code:

  • womanSitting is 5px wider on the left, so the offset will need to change by 5px
  • manSitting is 14.5px wider total, 5.5px wider on the left and 9px wider on the right, so the offset will need to change by 3.5px.

amanda-phet added a commit that referenced this issue Dec 15, 2023
@amanda-phet
Add files via upload
fdfd648 
#140
amanda-phet added a commit that referenced this issue Dec 15, 2023
@amanda-phet
Delete assets/people.ai
bf56e22 
#140
Luisav1 added a commit that referenced this issue Dec 15, 2023
@Luisav1
Update licenses. See #140.
6dc3f59
Luisav1 added a commit that referenced this issue Dec 15, 2023
@Luisav1
Add credits to licenses. See #140.
70f007d
@amanda-phet amanda-phet changed the title Add in Africa/ Modest, Asia, and Latin America character sets Add in Africa/ Modest, Asia, Oceania, and Latin America character sets Dec 15, 2023
@amanda-phet
Copy link
Contributor

amanda-phet commented Jan 5, 2024 •
edited
Loading

As part of this work, should we have regional screen and game icons @kathy-phet ? There is one screen icon and two game icons that use characters.

image

image

Also, reminder to myself that we want to make new screen icons for this sim that showcase different regions.

amanda-phet added a commit that referenced this issue Jan 10, 2024
@amanda-phet
Add files via upload
5de0c1c 
#140
amanda-phet added a commit that referenced this issue Jan 10, 2024
@amanda-phet
Add files via upload
372188f 
#140
@amanda-phet
Copy link
Contributor

Screen icons are uploaded to the /images directory, with the Lab screen icons in regional folders. The game level icons are also in the /image directory, but the originals are in /mipmaps. Let me know if you have any questions about where any of the files live!

amanda-phet referenced this issue Jan 10, 2024
@amanda-phet
Add files via upload
e1d6618 
phetsims/forces-and-motion-basics#304
#145
amanda-phet added a commit that referenced this issue Jan 10, 2024
@amanda-phet
Delete assets/game-icon.ai
2ba4f3d 
#140
#145
amanda-phet added a commit that referenced this issue Jan 10, 2024
@amanda-phet
Delete assets/game-level-1-icon.ai
873dbef 
#140
#145
amanda-phet added a commit that referenced this issue Jan 10, 2024
@amanda-phet
Delete assets/game-level-2-icon.ai
910e897 
#140
#145
amanda-phet added a commit that referenced this issue Jan 10, 2024
@amanda-phet
Delete assets/game-level-3-icon.ai
8824e5e 
#140
#145
amanda-phet added a commit that referenced this issue Jan 10, 2024
@amanda-phet
Delete assets/game-level-4-icon.ai
b6574bd 
#140
#145
amanda-phet added a commit that referenced this issue Jan 10, 2024
@amanda-phet
Delete assets/intro-icon-small.ai
2f7e65a 
#140
#145
amanda-phet added a commit that referenced this issue Jan 10, 2024
@amanda-phet
Delete assets/intro-icon.ai
ddfc803 
#140
#145
amanda-phet added a commit that referenced this issue Jan 10, 2024
@amanda-phet
Delete assets/lab-icon-small.ai
1b4eff4 
#140
#145
amanda-phet added a commit that referenced this issue Jan 10, 2024
@amanda-phet
Delete assets/lab-icon.ai
5abb066 
#140
#145
Luisav1 added a commit that referenced this issue Jan 11, 2024
@Luisav1
Update image licenses and create their typescript files. See #140.
c54d5bf
Luisav1 added a commit that referenced this issue Jan 11, 2024
@Luisav1
Use svg images for USA portrayals. Remove unused pngs in mimaps. See #…
3692b31 
…140.
Luisav1 added a commit that referenced this issue Jan 11, 2024
@Luisav1
Use the regular screen icon image for both the home and nav screen ic…
5a33873 
…ons. Remove unused pngs and ts files for pngs, though leave the pngs for small icons. See #140.
Luisav1 added a commit that referenced this issue Jan 11, 2024
@Luisav1
Use the svg images for objects. Remove unused object pngs and ts file…
593de26 
…s for pngs. See #140.
Luisav1 added a commit that referenced this issue Jan 12, 2024
@Luisav1
Use wood crate svg image, delete its png version and ts file. See #140.
a3aa0ee
Luisav1 added a commit that referenced this issue Jan 12, 2024
@Luisav1
Add portrayals for Africa, Africa modest, Asia, Latin America, and Oc…
27683df 
…eania. See #140.
Luisav1 added a commit that referenced this issue Jan 12, 2024
@Luisav1
Replace old object images and use svg images for plankBalanced, plank…
235b311 
…TippedRight, and plankTippedLeft. Remove unused pngs. See #140.
Luisav1 added a commit that referenced this issue Jan 17, 2024
@Luisav1
Use new womanSitting svg image. See #140 and #145.
3eef670
@amanda-phet amanda-phet removed their assignment Jan 22, 2024
Luisav1 added a commit that referenced this issue Jan 24, 2024
@Luisav1
Update JSDoc. See #140.
afb84ce
@Luisav1
Copy link
Contributor Author

Luisav1 commented Feb 9, 2024

Closing since all the character sets are added in and integrated well.

@Luisav1 Luisav1 closed this as completed Feb 9, 2024
@phet-dev
Copy link
Contributor

Reopening because there is a TODO marked for this issue.

@phet-dev phet-dev reopened this Feb 10, 2024
@Luisav1
Copy link
Contributor Author

Luisav1 commented Apr 10, 2024

Closing since it seems there are no TODOs pointing to this issue anymore.

@Luisav1 Luisav1 closed this as completed Apr 10, 2024
@Luisav1 Luisav1 mentioned this issue Apr 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Luisav1 Luisav1

Labels
design:artwork
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kathy-phet @amanda-phet @phet-dev @Luisav1