-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mvc\Model::snapshot data cast #14377
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsilbi
commented
Sep 11, 2019
zsilbi
force-pushed
the
model-snapshot-cast
branch
from
September 17, 2019 20:45
ed0338d
to
0c30d06
Compare
zsilbi
force-pushed
the
model-snapshot-cast
branch
from
September 17, 2019 20:48
0c30d06
to
d62f8d1
Compare
This reverts commit 4595191
Codecov Report
@@ Coverage Diff @@
## 4.0.x #14377 +/- ##
==========================================
- Coverage 67.63% 67.5% -0.14%
==========================================
Files 478 478
Lines 110989 110991 +2
==========================================
- Hits 75069 74924 -145
- Misses 35920 36067 +147 |
ruudboon
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
When
orm.cast_on_hydrate
is on, I thinkModel::cloneResultMap()
should save the casted values to the snapshot data.If it's off, then
Model::getChangedFields()
should not use===
to check if the field has changed.Thanks,
zsilbi