Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mvc\Model::snapshot data cast #14377

Merged
merged 8 commits into from
Sep 18, 2019
Merged

Mvc\Model::snapshot data cast #14377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b738e13
When orm.cast_on_hydrate is on, Model::cloneResultMap() saves the casted
zsilbi Sep 10, 2019
2743759
If orm.cast_on_hydrate is off, Model::getChangedFields() won't use ===
zsilbi Sep 10, 2019
4595191
Updated HasChangedCest
zsilbi Sep 10, 2019
9829375
Fixed conditions
zsilbi Sep 10, 2019
47df6d9
Revert "Fixed conditions"
Sep 17, 2019
418c3ea
Revert "If orm.cast_on_hydrate is off, Model::getChangedFields() won'…
Sep 17, 2019
d62f8d1
Added changelog
Sep 17, 2019
0fc8a80
Revert "Updated HasChangedCest"
Sep 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG-4.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
- Fixed `Phalcon\Mvc\Model\Query\Builder` Empty table alias in query [#14366](https://github.com/phalcon/cphalcon/issues/14366)
- Fixed `Phalcon/Db/Adapter/PdoFactory` to reference the correct interface [#14381](https://github.com/phalcon/cphalcon/pull/14381)
- Fixed `Phalcon/Db/Dialect/Mysql` Fixed missing schema in constraint for create table [#14378](https://github.com/phalcon/cphalcon/issues/14378)
- Fixed `Phalcon\Mvc\Model::hasChanged()` and `getChangedFields()` returning false values when `castOnHydrate` option is on. [#14376](https://github.com/phalcon/cphalcon/issues/14376)

## Removed
- Removed `Phalcon\Plugin` - duplicate of `Phalcon\DI\Injectable` [#14359](https://github.com/phalcon/cphalcon/issues/14359)
Expand Down
3 changes: 2 additions & 1 deletion phalcon/Mvc/Model.zep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -793,7 +793,8 @@ abstract class Model extends AbstractInjectionAware implements EntityInterface,
}

let attributeName = attribute[0],
instance->{attributeName} = castValue;
instance->{attributeName} = castValue,
data[key] = castValue;
}

/**
Expand Down