Model::hasChanged() and getChangedFields() return false values

[zsilbi]

When snapshot data is saved to a Model, all attributes are being saved as string.
There can be issues regardless orm.cast_on_hydrate is turned on or off.

Here is a quick example:

class Robots extends \Phalcon\Mvc\Model
{
    public $id; // unsigned int(10) in MySQL
    public $year; // unsigned int(10) in MySQL

    public function initialize()
    {
        $this->keepSnapshots(true);
    }
}

/****************************************/
ini_set('phalcon.orm.cast_on_hydrate', 0);

$robot = Robots::findFirst();

var_dump($robot->toArray()); // array(2) { ["id"] => string(1) "1" ["year"] => string(4) "1900" }

var_dump($robot->year); // string(4) "1900"

var_dump($robot->getSnapshotData()['year']); // string(4) "1900"

var_dump($robot->hasChanged('year')); // bool(false)

$robot->year = 1900;
var_dump($robot->hasChanged('year')); // bool(true)

$robot->year = "1900";
var_dump($robot->hasChanged('year')); // bool(false)

/****************************************/
ini_set('phalcon.orm.cast_on_hydrate', 1);

$robot = Robots::findFirst();

var_dump($robot->toArray()); // array(2) { ["id"] => int(1) ["year"] => int(1900) }

var_dump($robot->year); // int(1900)

var_dump($robot->getSnapshotData()['year']); // string(4) "1900"

var_dump($robot->hasChanged('year')); // bool(true)

$robot->year = 1900;
var_dump($robot->hasChanged('year')); // bool(true)

$robot->year = "1900";
var_dump($robot->hasChanged('year')); // bool(false)

When orm.cast_on_hydrate is on, I think Model::cloneResultMap() should save the casted values to the snapshot data.
If it's off, then Model::getChangedFields() should not use === to check if the field has changed.

Any thoughts?

Details

• Phalcon version: 4.0.x branch

[ruudboon]

cloneResultMap should save casted values when cast_on_hydrate is on.

I'm not sure if I agree not to use === when cast_on_hydrate is off.
When cast_on_hydrate is off you should accept that all your model properties are strings and should set them as string. If you set it as int I'm expecting that hasChanged will detect a change.

[zsilbi]

Resolved in #14377