-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T13336 find first null #13826
T13336 find first null #13826
Conversation
* upstream/4.0.x: [4.0.x] - Added unicode flag for email filter
* upstream/4.0.x: Updated changelog Updated CFLAG default build param keep the actionName as set, do cache the methodName in `getActiveMethod` instead (use action mapping to cover Dispatcher `forward`ing case?) move formatter into setter give up on `camelize`, use a new approach unit tests Camel-case the action name (before call in handler) Correct pull request template Fix .editorconfig Amended .gitignore Bump version Fixed preparing release on AppVeyor Update change log Regenerated build Regenerated ext Updating the changelog
* upstream/4.0.x: Update CHANGELOG-4.0.md Updated changelog Added geSetMetaData test Modified some unit tests to use metaData Modified existing tests to work with the additional MetaData Modified Phalcon\Mvc\Model to use Phalcon\Message::setMetaData() instead of setModel() Added new MetaData variable to Phalcon\Message. Modified Phalcon\MessageInterface accordingly Corrected typo
* upstream/4.0.x: [#2182] - Updated the changelog and PR template [#2182] - Added before/after compile events for Volt [#2182] - Removed some obsolete tests; Added tests for engine/render events Updated changelog fix tests change tests fix stan Add `Dispatcher::toCamelCase()` method [#13819] - Updated the changelog [#13819] - Removing css/js optimizers from the config [#13819] - Updating ext/ [#13819] - Removed minifiers [#13819] - Marked tests as skipped
cc @sergeyklay |
Codecov Report
@@ Coverage Diff @@
## 4.0.x #13826 +/- ##
==========================================
+ Coverage 66.24% 66.24% +<.01%
==========================================
Files 450 450
Lines 89628 89636 +8
==========================================
+ Hits 59375 59383 +8
Misses 30253 30253
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hello!
In raising this pull request, I confirm the following (please check boxes):
When passing anything other than a string, array or null in
findFirst()
will throw an exceptionThanks