ORM bug - search by primary key

[zvonchuk]

Expected and Actual Behavior

When searching for a record by primary key equal to false, then ORM simply selects the first record from the table.
I think it would be more logical if ORM returned an error.

Provide minimal script to reproduce the issue

$clientId = false;
$client   = (new \CRM\Client\Client)::findFirst ($clientId);
print_r($client->toArray());

Responce:

Details

• Phalcon version: 3.3.1
• PHP Version: PHP 7.1.13-1+020180105151310.14+jessie1.gbp1086fa
• Operating System: Debian GNU/Linux 8
• Installation type: installing via package manager
• Zephir version (if any): 0.10.7-2917ebe8ae
• Server: nginx/1.12.2
• Other related info (Database, table schema):
  mysql Ver 14.14 Distrib 5.5.55, for debian-linux-gnu (x86_64) using readline 6.3
  ENGINE=InnoDB

CREATE TABLE `client_base` (
  `id` int(11) unsigned NOT NULL AUTO_INCREMENT,
  PRIMARY KEY (`id`)
) ENGINE=InnoDB AUTO_INCREMENT=611788 DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci

[JABirchall]

Agreed, If the paramiter passed is not null the orm should throw an exeption if the primary key is no equal to the value passed.
While maintaining expected behavour if no value is passed or null to fetch the first row.

[niden]

This has been addressed