Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace minifiers (css/js) #13819

Closed
niden opened this issue Feb 11, 2019 · 6 comments
Closed

Replace minifiers (css/js) #13819

niden opened this issue Feb 11, 2019 · 6 comments
Labels
bug A bug report status: medium Medium

Comments

@niden
Copy link
Member

niden commented Feb 11, 2019

The current minifiers for JS/CSS rely on a library by Douglas Crockford and its license is "BSD with restriction".

We need to remove this library and replace it with one that does not have restrictions or roll out a in-house implementation.

The library needs to be removed from v4 but the Phalcon classes will remain as they are, returning back (for now) the original file i.e. pretty much doing nothing. This is in order to keep SemVer happy when we do roll out the new minifying library (in future versions of v4)

Reference: #10118

@niden niden added breaks bc Functionality that breaks Backwards Compatibility Bug - Medium labels Feb 11, 2019
@ruudboon
Copy link
Member

ruudboon commented Feb 11, 2019

With all the current tools (webpack, grunt, less, sass. typescript etc) that are available noways I'm wondering if this is still a wanted feature in the framework or that it should be removed from the framework.

@niden niden mentioned this issue Feb 11, 2019
3 tasks
@niden niden removed the breaks bc Functionality that breaks Backwards Compatibility label Feb 11, 2019
@dschissler

This comment was marked as abuse.

niden added a commit that referenced this issue Feb 12, 2019
niden added a commit that referenced this issue Feb 12, 2019
niden added a commit that referenced this issue Feb 12, 2019
niden added a commit that referenced this issue Feb 12, 2019
@niden
Copy link
Member Author

niden commented Feb 12, 2019

Resolved

@niden niden closed this as completed Feb 12, 2019
@dschissler

This comment was marked as abuse.

@david-duncan
Copy link

I couldn't agree more with the comments in this thread. Focus efforts on 7.4 and 8.x

@dschissler

This comment was marked as abuse.

@niden niden added the 4.0 label Jun 21, 2019
@niden niden added bug A bug report status: medium Medium and removed Bug - Medium labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: medium Medium
Projects
None yet
Development

No branches or pull requests

4 participants