3.4.2 #13626
Merged
3.4.2 #13626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix issue with validation on locales where comma used as decimal point * Add tests for Numericality locales where comma uses as decimal point * Update change log
This fixes the issue where if we parameters are specified, they also get rendered into the form element as parameters attribute because whole params array is passed to `self::renderAttributes`.
* upstream/3.4.x: (116 commits) Removed no longer used local variable from router.zep Bump version Removed configure.ac Fix issue with validation on locales where comma used (#13457) Update change log Regenerated build (PHP5) [ci skip] Regenerated build [ci skip] Regenerated build (PHP7) [ci skip] Update license Update backers & sponsors [ci-skip] use varuable "ns" instead of scale value "\\" default parameter value matches the type Update CONTRIBUTING.md [ci-skip] Cleaned README.md [ci-skip] Make feature requests visible on project's page [ci-skip] Spelling error Update compiler.zep Fixed Request::getPut to provide json content-type support adds tinyblob bindtype fix to changelog removes incorrect mysql tinyblob bindtype ...
Filename error
Unset params["parameters"]
Explicitly define nullable columns
* upstream/3.4.x: Added changelog for PR 13100 Update CHANGELOG-3.4.md Add documentation for Route::convert [ci skip] fix: quotes error docs: add change log fix: setFileToSend filename last much "_" Unset params["parameters"] Update PostgreSQL tests Update MySQL tests Explicitly define nullable columns
Issues shouldn't be marked as stale if they're confirmed bugs.
Travis is deprecating the sudo keyword and moves everything to the same infrastructure (sudo really selects between two infrastructures). See: https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration
nice to have
Update email address to team@phalconphp.com
niden
approved these changes
Dec 2, 2018
niden
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.