Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Response::setFileToSend to append ; at the end of line #13496

Merged
merged 3 commits into from
Oct 4, 2018
Merged

Fixed Response::setFileToSend to append ; at the end of line #13496

merged 3 commits into from
Oct 4, 2018

Conversation

cq-z
Copy link
Contributor

@cq-z cq-z commented Sep 20, 2018 •
edited by sergeyklay
Loading

Hello!

  • Type: bug fix
  • Link to issue:

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change:

Fixed Phalcon\Http\Response::setFileToSend to append ; at the end of line

Thanks

@Jurigag
Copy link
Contributor

Jurigag commented Sep 21, 2018 •
edited
Loading

Why this is exactly an issue? Why we need to change this?

@cq-z
Copy link
Contributor Author

cq-z commented Sep 22, 2018

set filename=test.txt
download filename is test.txt_

@niden
Copy link
Member

niden commented Oct 4, 2018

Thank you for the contribution!

@niden niden merged commit 72cfb5e into phalcon:3.4.x Oct 4, 2018
@sergeyklay sergeyklay changed the title Filename error Fixed Response::setFileToSend to append ; at the end of line Oct 19, 2018
@sergeyklay sergeyklay added this to the 3.4.2 milestone Oct 19, 2018
@bbasinski bbasinski mentioned this pull request Mar 29, 2019
Closed
@niden niden added documentation Documentation required and removed documentation Documentation required labels Apr 9, 2019
@niden niden added 4.0 and removed 4.0 labels Dec 1, 2019
@niden niden added bug A bug report status: medium Medium and removed Bug - Medium labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niden niden niden approved these changes

Assignees
No one assigned
Labels
bug A bug report status: medium Medium
Projects
None yet
Milestone
3.4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@cq-z @Jurigag @niden @sergeyklay