Fix unit test for issue #12648 - Incorrect scope of view variables

[piit79]

Hello!

• Type: bug fix
• Link to issue: Variable scope when is set as view param and rendered by getRender() #12648

In raising this pull request, I confirm the following:

• I have read and understood the Contributing Guidelines?
• I have checked that another pull request for this purpose does not exist.
• I wrote some tests for this PR.

Small description of change:
The unit test for issue #12648 is incorrect and doesn't test the failure condition of the issue properly. The issue is marked as fixed but the problem is still present in 3.3.x.

Thanks
Petr Sedlacek

[piit79]

@sergeyklay Just to be sure, could you please take a look at the unit test and confirm it's correct? It seems strange to me nobody has complained about #12648 which makes me think if we're doing something wrong :) We're using parametric partials which does not work with PHP 7 (the variables leak between partials). Thanks for your help on this!

[sergeyklay]

/ cc @Jurigag

[sergeyklay]

@piit79 As I can see it happens only in Zend Engine 3 (PHP 7).

Refs: zephir-lang/zephir#1621, #12176

[piit79]

@sergeyklay that's right, we only started having the issue when we switched to PHP 7 recently (with the same code). Thanks for looking into this.

[sergeyklay]

@piit79 I'll try to sort out with this

[sergeyklay]

I hope we managed to sort out with this issue finally here #13606. All necessary changes are already in the appropriate branch. We will try to release the next version in the coming days. Thank you for your patience, the report, and for helping us make Phalcon better.

[piit79]

@sergeyklay That's great! Can you please point me to the branch? I'll do a quick test.

However, I see you haven't merged the fix for the unit test, can I ask why? It's still broken in master:

            try {
                echo $a_cool_var;
            } catch (\PHPUnit_Framework_Exception $e) {
                expect($e->getMessage())->contains("Undefined variable: a_cool_var");
            }

The problem is that if the variable $a_cool_var is actually set (which it should not), there will be no exception and the test will not catch this failure condition. That's why I added the fail() after the echo.

[sergeyklay]

Please see: #12648 (comment)