Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#13468] inconsistent naming convention in dispatcher #13524

Closed
wants to merge 7 commits into from
Closed

[#13468] inconsistent naming convention in dispatcher #13524

wants to merge 7 commits into from

Conversation

niden
Copy link
Member

@niden niden commented Oct 15, 2018

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Added missing methods; ability to retrieve properties from the dispatcher

Thanks

@niden niden requested a review from sergeyklay October 15, 2018 14:21
@niden niden added Bug - Medium enhancement Enhancement to the framework labels Oct 17, 2018
@niden
Copy link
Member Author

niden commented Oct 18, 2018

cc @sergeyklay


or

\Phalcon\Cli\Dispatcher::getTaskSuffix()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these lines with method names need to be removed

@niden
Copy link
Member Author

niden commented Oct 18, 2018

Closing this to make necessary corrections and split the PR into 2.

@niden niden closed this Oct 18, 2018
@niden niden deleted the T13468-inconsistent-naming-convention-in-dispatcher branch October 31, 2018 17:45
@niden niden added documentation Documentation required and removed documentation Documentation required labels Apr 9, 2019
@niden niden added the 4.0 label Dec 1, 2019
@niden niden added bug A bug report status: medium Medium and removed Bug - Medium labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report enhancement Enhancement to the framework status: medium Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants