Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#13468] inconsistent naming convention in dispatcher #13524

Closed
wants to merge 7 commits into from
Closed

[#13468] inconsistent naming convention in dispatcher #13524

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
20c777f
Added the getTaskSuffix method in the interface
niden Oct 10, 2018
2c76a73
Added the suffix getter in the CLI dispatcher
niden Oct 10, 2018
9c247a7
Added getHandlerSuffix and setHandlerSuffix in the dispatcher interface
niden Oct 10, 2018
cce57ef
Reorganized methods (alpha)
niden Oct 11, 2018
1fb7dca
Added handler suffix setter
niden Oct 11, 2018
f9d033a
Corrected method name
niden Oct 11, 2018
8df60ff
Updated the changelog
niden Oct 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Updated the changelog
  • Loading branch information
@niden
niden committed Oct 15, 2018
commit 8df60ff2a185c2f8030e622a88708d3c4be654ed
8 changes: 8 additions & 0 deletions CHANGELOG-4.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@
- Added `Phalcon\Mvc\Router\RouteInterface::convert` so that calling `Phalcon\Mvc\Router\Group::add` will return an instance that has `convert` method [#13380](https://github.com/phalcon/cphalcon/issues/13380)
- Added `Phalcon\Mvc\ModelInterface::getModelsMetaData` [#13070](https://github.com/phalcon/cphalcon/issues/13402)
- Added `paginate()` method as a proxy of `getPaginate`. Added `previous` in the paginator object same as `before`. After 4.0 is released we will deprecate `getPaginate()`, `before` and `total_items` [#13492](https://github.com/phalcon/cphalcon/issues/13492)
- Added `getHandlerSuffix()`, `setHandlerSuffix()` in Dispatcher, `getTaskSuffix()`, `setTaskSuffix()` in the CLI Dispatcher [#13468](https://github.com/phalcon/cphalcon/issues/13468)

\Phalcon\Dispatcher::getHandlerSuffix()
\Phalcon\Dispatcher::setHandlerSuffix()

or

\Phalcon\Cli\Dispatcher::getTaskSuffix()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these lines with method names need to be removed


## Changed
- By configuring `prefix` and `statsKey` the `Phalcon\Cache\Backend\Redis::queryKeys` no longer returns prefixed keys, now it returns original keys without prefix. [#13456](https://github.com/phalcon/cphalcon/pull/13456)
Expand Down