Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent naming convention in Dispatcher classes, no way to retrieve a settable value (handler suffix) #13468

Closed
terax6669 opened this issue Aug 20, 2018 · 1 comment
Assignees
Labels
breaks bc Functionality that breaks Backwards Compatibility
Milestone

Comments

@terax6669
Copy link

Expected and Actual Behavior

Expected:

Available methods:

\Phalcon\Dispatcher::getHandlerSuffix()
\Phalcon\Dispatcher::setHandlerSuffix()

or

\Phalcon\Cli\Dispatcher::getTaskSuffix()

Actual

There is a \Phalcon\Cli\Dispatcher::setTaskSuffix() method that sets _handlerSuffix - this is inconsistent.
After using setTaskSuffix there is no way to read the new value from the dispatcher.

Details

  • Phalcon version: 3.4.1
@niden niden self-assigned this Oct 15, 2018
niden added a commit that referenced this issue Oct 18, 2018
…ntion-in-dispatcher-2

[#13468] - Added `getHandlerSuffix()`, `setHandlerSuffix()` in Dispatcher
@niden niden added this to the 4.0.0 milestone Oct 19, 2018
@niden niden added the breaks bc Functionality that breaks Backwards Compatibility label Oct 19, 2018
@niden
Copy link
Member

niden commented Oct 19, 2018

This has been implemented in 4.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks bc Functionality that breaks Backwards Compatibility
Projects
None yet
Development

No branches or pull requests

2 participants